-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace local module with shared folder #1144
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a0c57ee
chore(backend): clean up unused options in tsconfig
lamkeewei 5ba3e19
feat: add shared folder
lamkeewei e0c461e
chore(backend): use shared folder
lamkeewei a0cf500
chore(worker): use shared folder
lamkeewei 0cd675b
chore(shared): update package-lock.json
lamkeewei 32d343f
Merge branch 'develop' into shared-folder
lamkeewei b52fc6c
fix(backend): update jest module aliases and commands
lamkeewei 16afd03
chore(frontend): use shared folder
lamkeewei f0c7f08
chore: include shared folder in npm commands
lamkeewei b8a901a
chore: remove modules folder
lamkeewei b8f989d
chore: fix sentry source map upload
lamkeewei 1b529cc
chore: bump shared package version and update README
lamkeewei 45e8b4b
chore: add travis job to build and test shared module
lamkeewei cffc5b1
Merge branch 'develop' into shared-folder
lamkeewei 1cfa59d
Merge branch 'develop' into shared-folder
lamkeewei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help explain why we didn't need the build step previously but have included it now? I guess its to build the shared module, but where was the backend being built previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - this is to build the shared module. Previously there was not need to separate build the backend because
npm test
handles it. However,ts-jest
does not automatically compile project references.