Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend tests for campaign middleware and sms campaign routes #1146

Merged
merged 20 commits into from May 19, 2021
Merged

Backend tests for campaign middleware and sms campaign routes #1146

merged 20 commits into from May 19, 2021

Conversation

miazima
Copy link
Contributor

@miazima miazima commented Apr 22, 2021

Tests:

  • campaign middleware - canEditCampaign
  • email, sms and telegram middleware - isCampaignOwnedByUser
  • sms campaign routes
    • GET /campaign/{id}/sms
    • PUT /campaign/{id}/sms/template
    • GET /campaign/{id}/sms/upload/start
    • POST /campaign/{id}/sms/upload/complete

@miazima miazima marked this pull request as ready for review April 22, 2021 03:34
Base automatically changed from backend-tests to develop May 4, 2021 03:05
lamkeewei
lamkeewei reviewed May 10, 2021
View reviewed changes
Copy link
Contributor

@lamkeewei lamkeewei left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions and clean up required. Also, should we include the tests for the other channels (Email and Telegram) in this PR also?

.travis.yml Outdated Show resolved Hide resolved
backend/src/email/middlewares/tests/email.middleware.test.ts Outdated Show resolved Hide resolved
backend/src/email/middlewares/tests/email.middleware.test.ts Outdated Show resolved Hide resolved
backend/src/sms/routes/tests/sms-campaign.routes.test.ts Outdated Show resolved Hide resolved
backend/src/sms/routes/tests/sms-campaign.routes.test.ts Outdated Show resolved Hide resolved
@lamkeewei
Copy link
Contributor

@miazima could I get your help to resolve the merge conflicts? Thanks!

lamkeewei
lamkeewei approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@lamkeewei lamkeewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lamkeewei lamkeewei merged commit fca72af into develop May 19, 2021
@lamkeewei lamkeewei deleted the backend-tests-middleware branch May 19, 2021 01:47
lamkeewei added a commit that referenced this pull request May 27, 2021
@lamkeewei
Merge branch 'develop' into graceful-workers
cf5ad0d 
* develop:
  chore: replace local module with shared folder (#1144)
  1.24.0
  Backend tests for campaign middleware and sms campaign routes (#1146)
  chore: upgrade dependencies (#1180)
lamkeewei added a commit that referenced this pull request May 28, 2021
@lamkeewei
Merge branch 'develop' into feat-custom-sender-name
1c2c92f 
* develop:
  chore: replace local module with shared folder (#1144)
  1.24.0
  Backend tests for campaign middleware and sms campaign routes (#1146)
  chore: upgrade dependencies (#1180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamkeewei lamkeewei lamkeewei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miazima @lamkeewei