Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): docker build and tsc output directory structure #1177

Merged
merged 2 commits into from
May 7, 2021
Merged

fix(backend): docker build and tsc output directory structure #1177

merged 2 commits into from
May 7, 2021

Conversation

lamkeewei
Copy link
Contributor

Problem

Deployments for backends were failing after merging #940 because:

  1. tsconfig.build.json was not copied into the image during Docker build
  2. rootDir was changed in backend/tsconfig.json, this results in a different build directory structure being created. npm start fails because server.js now resides in build/src/server.js.

Solution

Bug Fixes:

  • Copied tsconfig.build.json into the Docker image
  • Reverted rootDir to ./src. Also reverted baseUrl for consistency.

Tests

  • Deploy this branch and observe that the Elastic Beanstalk deploy succeeds on AWS console

@lamkeewei lamkeewei requested a review from miazima May 5, 2021 18:57
miazima
miazima approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@miazima miazima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on staging and elastic beanstalk successfully deployed

@miazima miazima merged commit b9d498e into develop May 7, 2021
@miazima miazima deleted the fix-backend-docker-build branch May 7, 2021 02:04
lamkeewei added a commit that referenced this pull request May 7, 2021
@lamkeewei
Merge branch 'develop' into shared-folder
cffc5b1 
* develop:
  fix(backend): docker build and tsc output directory structure (#1177)
  feat: refactor msg template components; add telegram character limit (#1148)
lamkeewei added a commit that referenced this pull request May 10, 2021
@lamkeewei
Merge branch 'develop' into feat-image-links
6876fa2 
* develop:
  fix: fix error when updating Telegram ID for an existing phone number (#1178)
  chore: upgrade React; use new JSX transform; sort imports (#1129)
  fix(backend): docker build and tsc output directory structure (#1177)
  feat: refactor msg template components; add telegram character limit (#1148)
  refactor: use shared function to initialize models (#1172)
  chore: setup scaffolding for backend tests (#940)
  1.23.0
  fix(frontend): fix frontend test flakiness (#1162)
  fix: update successful delivery status only if error does not exist (#1150)
  chore: upgrade dependencies (#1153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miazima miazima miazima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lamkeewei @miazima