-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi variable linear regression #5
Conversation
# Conflicts: # opengrid/library/analysis.py
… tests with unquoting run fine.
Maybe @JrtPec can have a quick look and merge? |
1 similar comment
I have looked at the code, it is mostly what we've already seen before so its fine. I have only 1 style issue: the use of You'll also need to deliver the material to add the analysis to the website though. We will go through that process next meeting ;-) |
Thanks Jan. I had merged it already because of some code I'm running at 3E that needed the regression in the last pypi release. Good point on kwargs in init. I'll change that. |
I ported the regression to our new library. Main change: improved the handling of column names in the passed dataframe and now it is fully tested.