Refactor #100
Merged
Refactor #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Reading address from byte array. Almost trivial, need to account for a difference between mload's word size (32 bytes) and address size (20). 2. Transform 'bytes' to 'bytes32'. Is indeed trivial, only need to read 32 bytes starting at 'offset' (aka 'index'). Can be copied into RelayHub. Also, set Solc version as 0.5.5 because required by '@0x' package.
We will need the 'getMethodSig' method for the penalize flow (methods whitelist). All methods in the Utils are 'public pure', so they should really be deployed once.
After making all methods in the Recipient Utils 'internal', there is no longer need to deploy the library - the code is inlined by solidity.
It is used in the RelayHub as well.
drortirosh
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.