Add 'solidity-coverage' node command to the project #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current 'solidity-coverage' does not support solidity 0.5.0 and up, so it relies on patcking the 'parser.js' file in the meantime. Also, the "instrumented" version of the RelayHub contract is too large, so we need to add a large gas limit to it's migration sctipt, as well as run the ganache for coverage with the "allowUnlimitedContractSize" flag. Note: need to fix "skipFiles" behavior as it does not seem to work. Note 2: Many tests fail in coverage mode, which must be related to a change in the number of logs/amounts of gas consumed, etc. Needs fixing.
forshtat
force-pushed
the
solidity-coverage
branch
from
9e8ab6f
to
beed86e
Compare
added 2 commits
May 30, 2019 15:21
solcover patches the code in the coverageEnv folder, just for coverage tests, so that "npm test" will work normally.
|
@alex-forshtat-tbk : I think we should close this one. solidity-coverage is too problematic: by requiring modifying the contracts, it breaks our tests, which are gas-dependent. |
|
not used: too much code modification and gas manipulation (and thus breaking tests). used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current 'solidity-coverage' does not support solidity 0.5.0 and up, so
it relies on patcking the 'parser.js' file in the meantime.
Also, the "instrumented" version of the RelayHub contract is too large,
so we need to add a large gas limit to it's migration sctipt, as well as
run the ganache for coverage with the "allowUnlimitedContractSize" flag.
Note: need to fix "skipFiles" behavior as it does not seem to work.
Note 2: Many tests fail in coverage mode, which must be related to a
change in the number of logs/amounts of gas consumed, etc. Needs fixing.