Skip to content

Commit

Permalink
[jinja] disable failOnUnknownTokens (#16347)
Browse files Browse the repository at this point in the history
Home Assistant doesn't enable strict mode, so we shouldn't either

Signed-off-by: Cody Cutrer <cody@cutrer.us>
  • Loading branch information
ccutrer committed Feb 4, 2024
1 parent 8d8e169 commit 24f54f5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.hubspot.jinjava.Jinjava;
import com.hubspot.jinjava.JinjavaConfig;
import com.hubspot.jinjava.interpret.FatalTemplateErrorsException;

/**
Expand All @@ -47,8 +46,7 @@ public class JinjaTransformationService implements TransformationService {

private final Logger logger = LoggerFactory.getLogger(JinjaTransformationService.class);

private final JinjavaConfig config = JinjavaConfig.newBuilder().withFailOnUnknownTokens(true).build();
private final Jinjava jinjava = new Jinjava(config);
private final Jinjava jinjava = new Jinjava();

/**
* Transforms the input <code>value</code> by Jinja template.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,13 @@ public void testTemplateError() {
}

@Test
public void testMissingVariableError() {
assertThrows(TransformationException.class,
() -> processor.transform("Hello {{ missing }}!", "{\"string\": \"world\"}"));
public void testMissingVariableError() throws TransformationException {
assertEquals("Hello !", processor.transform("Hello {{ missing }}!", "{\"string\": \"world\"}"));
}

@Test
public void testMissingMapKeyError() {
assertThrows(TransformationException.class,
() -> processor.transform("Hello {{ value_json.missing }}!", "{\"string\": \"world\"}"));
public void testMissingMapKeyError() throws TransformationException {
assertEquals("Hello !", processor.transform("Hello {{ value_json.missing }}!", "{\"string\": \"world\"}"));
}

@Test
Expand Down

0 comments on commit 24f54f5

Please sign in to comment.