Apply suggestions from code review

Seems ok Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: aviborg <andreas.viborg@gmail.com> Signed-off-by: AndreasV <andreas.viborg@gmail.com>
openhab · Sep 24, 2023 · 2def0ce · 2def0ce
1 parent 1b9e2a9
commit 2def0ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/...c/main/java/org/openhab/binding/tellstick/internal/local/dto/TellstickLocalDeviceDTO.java b/...c/main/java/org/openhab/binding/tellstick/internal/local/dto/TellstickLocalDeviceDTO.java
@@ -118,13 +118,12 @@ public boolean equals(Object obj) {
         if (this == obj) {
             return true;
         }
-        if (obj == null) {
+        if (!(obj instanceof TellstickLocalDeviceDTO other)) {
             return false;
         }
         if (getClass() != obj.getClass()) {
             return false;
         }
-        TellstickLocalDeviceDTO other = (TellstickLocalDeviceDTO) obj;
         return deviceId == other.deviceId;
     }
 

diff --git a/...c/main/java/org/openhab/binding/tellstick/internal/local/dto/TellstickLocalSensorDTO.java b/...c/main/java/org/openhab/binding/tellstick/internal/local/dto/TellstickLocalSensorDTO.java
@@ -133,13 +133,12 @@ public boolean equals(Object obj) {
         if (this == obj) {
             return true;
         }
-        if (obj == null) {
+        if (!(obj instanceof TellstickLocalSensorDTO other)) {
             return false;
         }
         if (getClass() != obj.getClass()) {
             return false;
         }
-        TellstickLocalSensorDTO other = (TellstickLocalSensorDTO) obj;
         return deviceId == other.deviceId;
     }