Skip to content

Commit

Permalink
[homewizard] Applied review comments (#11639)
Browse files Browse the repository at this point in the history
Imported the (now slightly different) exception and feeding the numbers directly to a ZonedDateTime

Signed-off-by: Daniël van Os <daniel@supercell.nl>
  • Loading branch information
Daniel-42 committed Dec 1, 2021
1 parent 800f181 commit fcc7e2e
Showing 1 changed file with 13 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
package org.openhab.binding.homewizard.internal;

import java.io.IOException;
import java.time.DateTimeException;
import java.time.ZoneId;
import java.time.ZonedDateTime;
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.TimeUnit;

Expand Down Expand Up @@ -182,32 +185,31 @@ private void pollingCode() {
new QuantityType<>(payload.getTotalGasM3(), SIUnits.CUBIC_METRE));

// 210119164000
long seconds = dtv % 100;
int seconds = (int) (dtv % 100);

dtv /= 100;
long minutes = dtv % 100;
int minutes = (int) (dtv % 100);

dtv /= 100;
long hours = dtv % 100;
int hours = (int) (dtv % 100);

dtv /= 100;
long day = dtv % 100;
int day = (int) (dtv % 100);

dtv /= 100;
long month = dtv % 100;
int month = (int) (dtv % 100);

dtv /= 100;
long year = dtv + 2000;
int year = (int) (dtv + 2000);

String dateString = String.format("%04d-%02d-%02dT%02d:%02d:%02d", year, month, day, hours, minutes,
seconds);
try {
DateTimeType dtt = DateTimeType.valueOf(dateString);
DateTimeType dtt = new DateTimeType(
ZonedDateTime.of(year, month, day, hours, minutes, seconds, 0, ZoneId.systemDefault()));
updateState(HomeWizardBindingConstants.CHANNEL_GAS_TIMESTAMP, dtt);
updateState(HomeWizardBindingConstants.CHANNEL_TOTAL_GAS,
new QuantityType<>(payload.getTotalGasM3(), SIUnits.CUBIC_METRE));
} catch (java.time.format.DateTimeParseException e) {
logger.warn("Unable to parse Gas timestamp {} / {}", payload.getGasTimestamp(), dateString);
} catch (DateTimeException e) {
logger.warn("Unable to parse Gas timestamp: {}", payload.getGasTimestamp());
}
}
}
Expand Down

0 comments on commit fcc7e2e

Please sign in to comment.