[unifi] Thing configuration changes are not reloaded

[jlaur]

When changing configuration options like the considerHome value, this is not automatically picked up by the binding.

Expected Behavior

Configuration changes should take effect automatically and instantly.

Current Behavior

Old configuration values will be considered. So for example, it considerHome is changed from 60 to 180 seconds, client will still be marked as offline after one minute.

Possible Solution

I added this logging to UniFiClientThingHandler method initialize in else:

        // mgb: called when the config changes
        if (thing.getStatus() == INITIALIZING) {
            [...]
        } else {
            logger.debug("initialize() called, thing {} status is {}, existing consider home: {}, new: {}",
                    thing.getUID(), thing.getStatus(), this.config.getConsiderHome(), config.getConsiderHome());
        }

Result:

2021-10-18 20:49:20.974 [DEBUG] [rnal.handler.UniFiClientThingHandler] - initialize() called, thing unifi:wirelessClient:home:oneplus8_jacob status is ONLINE, existing consider home: 60, new: 180

So it seems that updating config only for things in status INITIALIZING is not sufficient.

Steps to Reproduce

For file-based configuration create a wirelessClient thing like this:

Thing wirelessClient oneplus8_jacob "UniFi Wireless Client: OnePlus 8 (Jacob)" [ cid="192.168.0.28", considerHome=60 ]

Then change it to:

Thing wirelessClient oneplus8_jacob "UniFi Wireless Client: OnePlus 8 (Jacob)" [ cid="192.168.0.28", considerHome=180 ]

and observe that client will still be marked as offline after one minute. Please be aware that this example will currently not work because of #7001, so it's kind of theoretical, but when #7001 is fixed, this bug will start appearing.

Context

I was testing a fix for #7001 and changed value a few times to not have to wait too long during my tests.

Your Environment

UniFi Controller 6.2.26

[openhab-bot]

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/ubiquiti-unifi-binding-feature-discussion/14520/1220