[hdpowerview] Shades are marked as offline with communication error during startup

[jlaur]

The Hunter Douglas PowerView binding has some concurrency issues during startup which results in shades being marked as offline for a minute, after state has changed a few times.

Expected Behavior

Shades should be reported as online as soon as possible when they are in fact online.

Current Behavior

When binding is started, I always observe this behaviour:

2021-12-04 23:41:19.829 [INFO ] [ab.event.ThingStatusInfoChangedEvent] - Thing 'hdpowerview:hub:hub' changed from INITIALIZING to ONLINE
2021-12-04 23:41:19.832 [DEBUG] [ternal.handler.HDPowerViewHubHandler] - Received data for 11 shades
2021-12-04 23:41:19.858 [DEBUG] [ternal.handler.HDPowerViewHubHandler] - Updating shade '42949'
2021-12-04 23:41:19.924 [INFO ] [ab.event.ThingStatusInfoChangedEvent] - Thing 'hdpowerview:shade:hub:blind4' changed from UNINITIALIZED (BRIDGE_UNINITIALIZED) to INITIALIZING
2021-12-04 23:41:19.967 [INFO ] [ab.event.ThingStatusInfoChangedEvent] - Thing 'hdpowerview:shade:hub:blind4' changed from INITIALIZING to ONLINE
2021-12-04 23:41:19.970 [INFO ] [ab.event.ThingStatusInfoChangedEvent] - Thing 'hdpowerview:shade:hub:blind4' changed from ONLINE to OFFLINE (COMMUNICATION_ERROR)
2021-12-04 23:42:20.554 [INFO ] [ab.event.ThingStatusInfoChangedEvent] - Thing 'hdpowerview:shade:hub:blind4' changed from OFFLINE (COMMUNICATION_ERROR) to ONLINE

HDPowerViewHubHandler calls HDPowerViewShadeHandler.onReceiveUpdate after receiving shade data from the hub. This marks the thing online:

    protected void onReceiveUpdate(@Nullable ShadeData shadeData) {
        if (shadeData != null) {
            updateStatus(ThingStatus.ONLINE);

However, this is last line of initialize:

        updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR);

Possible Solution

Not sure, but maybe initial status should be taken from bridge:

• Bridge is online: ONLINE.
• Bridge is offline: OFFLINE with ThingStatusDetail.BRIDGE_OFFLINE.
• No bridge: OFFLINE with ThingStatusDetail.BRIDGE_UNINITIALIZED.

Steps to Reproduce

Restart binding:
ssh openhab@localhost -p8101 'bundle:restart org.openhab.binding.hdpowerview'