Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enocean] Incorrectly discovers many devices as "Enocean USB300 Dongle" because 0403:6001 is used by many (FTDI) USB to serial converters #4421

Closed
wborn opened this issue Dec 21, 2018 · 3 comments · Fixed by #4431

Comments

@wborn
Copy link
Member

wborn commented Dec 21, 2018

Finally I had a look at how the UsbSerialDiscoveryParticipant works by inspecting the EnOceanUsbSerialDiscoveryParticipant.

Apparently it uses a very common USB vendor/product ID for matching the Dongle:
https://github.com/openhab/openhab2-addons/blob/af628c6a58bf8f7334dbcb1617147ec62c08fb6d/addons/binding/org.openhab.binding.enocean/src/main/java/org/openhab/binding/enocean/internal/discovery/EnOceanUsbSerialDiscoveryParticipant.java#L40-L41

All the USB to serial devices I use with openHAB have this vendor/product ID:

  • Plugwise Sticks
  • DSMR USB to serial converters

With lsusb it shows up as:

Bus 001 Device 008: ID 0403:6001 Future Technology Devices International, Ltd FT232 USB-Serial (UART) IC

So this greatly limits the usefulness of this kind of discovery.

Here's a screenshot of one of my Plugwise Sticks being detected as an EnOcean Dongle in Paper UI 😢 :

screenshot

@kaikreuzer
Copy link
Member

This indeed seems to be a bit too generic @fruggy83 :-( . The FTDI chip is indeed widespread and its product id should not be used to identify specific dongles like the USB300.

@fruggy83
Copy link
Contributor

Hi @kaikreuzer, I will see if I can narrow the discovery a little more.

@fruggy83
Copy link
Contributor

@wborn I have created a PR, could you check this with your FTDI devices? Thanks a lot 👍

wborn pushed a commit that referenced this issue Dec 28, 2018
…too (#4431)

Fixes #4421

Signed-off-by: Daniel Weber <uni@fruggy.de>
chaton78 pushed a commit to chaton78/openhab-addons that referenced this issue Jan 1, 2019
…too (openhab#4431)

Fixes openhab#4421

Signed-off-by: Daniel Weber <uni@fruggy.de>
Signed-off-by: Pascal Larin <plarin@gmail.com>
ne0h pushed a commit to ne0h/openhab-addons that referenced this issue Sep 15, 2019
…too (openhab#4431)

Fixes openhab#4421

Signed-off-by: Daniel Weber <uni@fruggy.de>
Signed-off-by: Maximilian Hess <mail@ne0h.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants