Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] Support short/long pressed CoAP events #7558

Closed
markus7017 opened this issue May 6, 2020 · 1 comment · Fixed by #7563
Closed

[shelly] Support short/long pressed CoAP events #7558

markus7017 opened this issue May 6, 2020 · 1 comment · Fixed by #7563
Labels
bug An unexpected problem or unintended behavior of an add-on PR pending There is a pull request for resolving the issue

Comments

@markus7017
Copy link
Contributor

Shelly introduced a new button type (momentary_on_release), which breaks the decoding of the event type for short/long pressed. In addition the binding was updading the item rather than triggering the channel.

Both are fixed

@markus7017 markus7017 added the bug An unexpected problem or unintended behavior of an add-on label May 6, 2020
markus7017 added a commit to markus7017/openhab-addons that referenced this issue May 6, 2020
Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017 added a commit to markus7017/openhab-addons that referenced this issue May 6, 2020
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
Copy link
Contributor Author

Included in PR#7563

@markus7017 markus7017 linked a pull request May 6, 2020 that will close this issue
@markus7017 markus7017 added the PR pending There is a pull request for resolving the issue label May 6, 2020
cpmeister pushed a commit that referenced this issue May 8, 2020
* Code base for PR 6335 based on 2.5.2-SNAPSHOT
* org.openhab.binding.magentatv added as module
* adapted to 2.5.4
* applying review comments - WIP
* changes WIP
* Changed the default of autoCoIoT to true in the Java class. This is
important when an existing installation is updated. Otherwise the
properties are loaded, autoCoIoT is not included and default was false.
* improved handling of short/longpush on CoAP updates; roller action urls
are not enforced on autoCoIoT
* #7558: Fixed short/long pressed events when reported by CoAP
* #7560: Resolve fqdn into IP address
* clean out files
* cleanout magentatv
* typo fixed

Signed-off-by: Markus Michels <markus7017@gmail.com>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this issue Jun 8, 2020
* Code base for PR 6335 based on 2.5.2-SNAPSHOT
* org.openhab.binding.magentatv added as module
* adapted to 2.5.4
* applying review comments - WIP
* changes WIP
* Changed the default of autoCoIoT to true in the Java class. This is
important when an existing installation is updated. Otherwise the
properties are loaded, autoCoIoT is not included and default was false.
* improved handling of short/longpush on CoAP updates; roller action urls
are not enforced on autoCoIoT
* openhab#7558: Fixed short/long pressed events when reported by CoAP
* openhab#7560: Resolve fqdn into IP address
* clean out files
* cleanout magentatv
* typo fixed

Signed-off-by: Markus Michels <markus7017@gmail.com>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this issue Jul 14, 2020
* Code base for PR 6335 based on 2.5.2-SNAPSHOT
* org.openhab.binding.magentatv added as module
* adapted to 2.5.4
* applying review comments - WIP
* changes WIP
* Changed the default of autoCoIoT to true in the Java class. This is
important when an existing installation is updated. Otherwise the
properties are loaded, autoCoIoT is not included and default was false.
* improved handling of short/longpush on CoAP updates; roller action urls
are not enforced on autoCoIoT
* openhab#7558: Fixed short/long pressed events when reported by CoAP
* openhab#7560: Resolve fqdn into IP address
* clean out files
* cleanout magentatv
* typo fixed

Signed-off-by: Markus Michels <markus7017@gmail.com>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this issue Jul 26, 2020
* Code base for PR 6335 based on 2.5.2-SNAPSHOT
* org.openhab.binding.magentatv added as module
* adapted to 2.5.4
* applying review comments - WIP
* changes WIP
* Changed the default of autoCoIoT to true in the Java class. This is
important when an existing installation is updated. Otherwise the
properties are loaded, autoCoIoT is not included and default was false.
* improved handling of short/longpush on CoAP updates; roller action urls
are not enforced on autoCoIoT
* openhab#7558: Fixed short/long pressed events when reported by CoAP
* openhab#7560: Resolve fqdn into IP address
* clean out files
* cleanout magentatv
* typo fixed

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
* Code base for PR 6335 based on 2.5.2-SNAPSHOT
* org.openhab.binding.magentatv added as module
* adapted to 2.5.4
* applying review comments - WIP
* changes WIP
* Changed the default of autoCoIoT to true in the Java class. This is
important when an existing installation is updated. Otherwise the
properties are loaded, autoCoIoT is not included and default was false.
* improved handling of short/longpush on CoAP updates; roller action urls
are not enforced on autoCoIoT
* openhab#7558: Fixed short/long pressed events when reported by CoAP
* openhab#7560: Resolve fqdn into IP address
* clean out files
* cleanout magentatv
* typo fixed

Signed-off-by: Markus Michels <markus7017@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
* Code base for PR 6335 based on 2.5.2-SNAPSHOT
* org.openhab.binding.magentatv added as module
* adapted to 2.5.4
* applying review comments - WIP
* changes WIP
* Changed the default of autoCoIoT to true in the Java class. This is
important when an existing installation is updated. Otherwise the
properties are loaded, autoCoIoT is not included and default was false.
* improved handling of short/longpush on CoAP updates; roller action urls
are not enforced on autoCoIoT
* openhab#7558: Fixed short/long pressed events when reported by CoAP
* openhab#7560: Resolve fqdn into IP address
* clean out files
* cleanout magentatv
* typo fixed

Signed-off-by: Markus Michels <markus7017@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
* Code base for PR 6335 based on 2.5.2-SNAPSHOT
* org.openhab.binding.magentatv added as module
* adapted to 2.5.4
* applying review comments - WIP
* changes WIP
* Changed the default of autoCoIoT to true in the Java class. This is
important when an existing installation is updated. Otherwise the
properties are loaded, autoCoIoT is not included and default was false.
* improved handling of short/longpush on CoAP updates; roller action urls
are not enforced on autoCoIoT
* openhab#7558: Fixed short/long pressed events when reported by CoAP
* openhab#7560: Resolve fqdn into IP address
* clean out files
* cleanout magentatv
* typo fixed

Signed-off-by: Markus Michels <markus7017@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
* Code base for PR 6335 based on 2.5.2-SNAPSHOT
* org.openhab.binding.magentatv added as module
* adapted to 2.5.4
* applying review comments - WIP
* changes WIP
* Changed the default of autoCoIoT to true in the Java class. This is
important when an existing installation is updated. Otherwise the
properties are loaded, autoCoIoT is not included and default was false.
* improved handling of short/longpush on CoAP updates; roller action urls
are not enforced on autoCoIoT
* openhab#7558: Fixed short/long pressed events when reported by CoAP
* openhab#7560: Resolve fqdn into IP address
* clean out files
* cleanout magentatv
* typo fixed

Signed-off-by: Markus Michels <markus7017@gmail.com>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this issue Sep 1, 2020
* Code base for PR 6335 based on 2.5.2-SNAPSHOT
* org.openhab.binding.magentatv added as module
* adapted to 2.5.4
* applying review comments - WIP
* changes WIP
* Changed the default of autoCoIoT to true in the Java class. This is
important when an existing installation is updated. Otherwise the
properties are loaded, autoCoIoT is not included and default was false.
* improved handling of short/longpush on CoAP updates; roller action urls
are not enforced on autoCoIoT
* openhab#7558: Fixed short/long pressed events when reported by CoAP
* openhab#7560: Resolve fqdn into IP address
* clean out files
* cleanout magentatv
* typo fixed

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 added a commit to markus7017/openhab-addons that referenced this issue Sep 19, 2020
* Code base for PR 6335 based on 2.5.2-SNAPSHOT
* org.openhab.binding.magentatv added as module
* adapted to 2.5.4
* applying review comments - WIP
* changes WIP
* Changed the default of autoCoIoT to true in the Java class. This is
important when an existing installation is updated. Otherwise the
properties are loaded, autoCoIoT is not included and default was false.
* improved handling of short/longpush on CoAP updates; roller action urls
are not enforced on autoCoIoT
* openhab#7558: Fixed short/long pressed events when reported by CoAP
* openhab#7560: Resolve fqdn into IP address
* clean out files
* cleanout magentatv
* typo fixed

Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on PR pending There is a pull request for resolving the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant