[lgwebos] Error in Volume subscriptions on 2020 LG webOS TVs

[sprehn]

On 2020 webOS LGTVs user @shmilgan reported that an error.

2020-11-08 19:42:39.470 [WARN ] [bos.internal.handler.LGWebOSTVSocket] - Error while processing message: {"type":"response","id":2,"payload":{"volumeStatus":{"activeStatus":true,"adjustVolume":true,"maxVolume":100,"muteStatus":false,"volume":11,"soundOutput":"tv_speaker","cause":"volumeUp"},"returnValue":true,"callerId":"com.webos.platformstarfish"}} - in response to request: ServiceCommand [type=subscribe, target=ssap://audio/getVolume, payload=null] - Error Message: null

Expected Behavior

Changes in volume via openhab or TV's remote should be correctly reflected on the bindings volume channel.

Current Behavior

No Update and Warning in logs.

Possible Solution

The volume subscription response format has changed. "volume" is now encapsulated in "volumeStatus".

{
   "type":"response",
   "id":2,
   "payload":{
      "volumeStatus":{
         "activeStatus":true,
         "adjustVolume":true,
         "maxVolume":100,
         "muteStatus":false,
         "volume":11,
         "soundOutput":"tv_speaker",
         "cause":"volumeUp"
      },
      "returnValue":true,
      "callerId":"com.webos.platformstarfish"
   }
} 

We need to adjust the response handler LGWebOSTVSocket:subscribeVolume and getVolume to handle both situations.

Steps to Reproduce (for Bugs)

1. Change volume on a 2020 LG WebOS TV paired with OH

[gilbertococchi]

+1 I was able to notice the same on LG 2020 55GX6LA:

2020-11-15 21:33:35.391 [WARN ] [bos.internal.handler.LGWebOSTVSocket] - Error while processing message: {"type":"response","id":699,"payload":{"volumeStatus":{"cause":"volumeDown","mode":"normal","adjustVolume":true,"activeStatus":true,"muteStatus":false,"volume":20,"soundOutput":"tv_speaker","maxVolume":100},"returnValue":true,"callerId":"com.webos.platformstarfish"}} - in response to request: ServiceCommand [type=subscribe, target=ssap://audio/getVolume, payload=null] - Error Message: null