[lgwebos][backport] Fix Volume subscription on newer LGWebOS TVs. #9414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some formatting issues. You can fix them with |
Signed-off-by: Andreas Olofsson <ao@blazar.se>
AndreasOlofsson
requested review from
3cky,
9037568,
alexf2015,
andrewfg,
aogorek,
bern77,
bjoernbrings,
bobadair,
BobRak,
caffineehacker,
cdjackson,
chaton78,
claell,
clinique,
Confectrician,
Cossey,
cpmeister,
CrackerStealth,
crnjan,
cschneider,
cweitkamp,
daMihe,
davidgraeff,
DerOetzi,
digitaldan and
dominicdesu
as code owners
wborn
added
rebuild
AndreasOlofsson
requested review from
trokohl,
wborn,
Wire82,
xylo,
yfre,
zarusz,
ZzetT and
a team
as code owners
|
Only critical fixes will be merged into the |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/lgwebos-binding-for-lg-webos-tvs/4726/820 |
|
Closing this as it only affects new models. Feel free to re-open, if you think this is not adequate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of pull request #9331 to 2.5.x, addressing issue #9000.
The Volume Change response in the API changed in newer LGWebOS TVs, see original pull request and issue for details.