Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[neato] NPE on discovery #9561

Closed
jjlauterbach opened this issue Dec 28, 2020 · 2 comments · Fixed by #9564
Closed

[neato] NPE on discovery #9561

jjlauterbach opened this issue Dec 28, 2020 · 2 comments · Fixed by #9564
Assignees
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@jjlauterbach
Copy link
Contributor

Current Behavior

There's a null pointer exception due to a null bridgeUID being passed to the ThingUID constructor.

2020-12-28 10:50:47.462 [WARN ] [mmon.WrappedScheduledExecutorService] - Scheduled runnable ended with an exception: 

java.lang.NullPointerException: null
    at org.openhab.core.thing.ThingUID.<init>(ThingUID.java:58) ~[?:?]
    at org.openhab.binding.neato.internal.discovery.NeatoAccountDiscoveryService.addThing(NeatoAccountDiscoveryService.java:97) ~[?:?]
    at org.openhab.binding.neato.internal.discovery.NeatoAccountDiscoveryService.findRobots(NeatoAccountDiscoveryService.java:60) ~[?:?]
    at org.openhab.binding.neato.internal.discovery.NeatoAccountDiscoveryService.lambda$0(NeatoAccountDiscoveryService.java:74) ~[?:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?]
    at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) ~[?:?]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
    at java.lang.Thread.run(Thread.java:834) [?:?]
@jjlauterbach jjlauterbach added the bug An unexpected problem or unintended behavior of an add-on label Dec 28, 2020
@jjlauterbach jjlauterbach self-assigned this Dec 28, 2020
jjlauterbach added a commit to jjlauterbach/openhab-addons that referenced this issue Dec 28, 2020
Signed-off-by: Jeff Lauterbach <jjlauterbach@gmail.com>
@jensflorian
Copy link

This is not related to #8931 ?

@jjlauterbach
Copy link
Contributor Author

No its not related to #8931. This seems to have been caused by changes for #8449. I'm not sure on the "correct" approach to resolve 8449 as bridgeUID is null when this code is being executed.

Am happy to work on a proper fix for obtaining the bridgeUID during discovery, but this PR addresses the NPE and allows items to be discovered again.

jjlauterbach added a commit to jjlauterbach/openhab-addons that referenced this issue Dec 29, 2020
Signed-off-by: Jeff Lauterbach <jjlauterbach@gmail.com>
@jjlauterbach jjlauterbach linked a pull request Dec 31, 2020 that will close this issue
jjlauterbach added a commit to jjlauterbach/openhab-addons that referenced this issue Jan 7, 2021
Signed-off-by: Jeff Lauterbach <jjlauterbach@gmail.com>
kaikreuzer pushed a commit that referenced this issue Jan 12, 2021
Signed-off-by: Jeff Lauterbach <jjlauterbach@gmail.com>
nowaterman pushed a commit to nowaterman/openhab-addons that referenced this issue Jan 19, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this issue May 10, 2021
Signed-off-by: Jeff Lauterbach <jjlauterbach@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this issue Nov 7, 2021
Signed-off-by: Jeff Lauterbach <jjlauterbach@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this issue May 5, 2022
Signed-off-by: Jeff Lauterbach <jjlauterbach@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants