[nanoleaf] Add Shapes & beta-firmware support #10029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s noisy Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
raepple
approved these changes
Feb 3, 2021
Hilbrand
requested changes
Feb 3, 2021
...enhab.binding.nanoleaf/src/main/java/org/openhab/binding/nanoleaf/internal/OpenAPIUtils.java
Outdated
Show resolved
Hide resolved
...g.nanoleaf/src/main/java/org/openhab/binding/nanoleaf/internal/NanoleafBindingConstants.java
Outdated
Show resolved
Hide resolved
...b.binding.nanoleaf/src/test/java/org/openhab/binding/nanoleaf/internal/OpenAPUUtilsTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
|
@Hilbrand It seems that committing directly from github one of you proposals wasn't a good idea as it misses "the signoff" and leads to the DCO required. I then changed everything locally and pushed it. Anything else I should do? |
|
Sign-off in this case is not a problem. This will be fixed when merging. Want needs to be done is run |
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
kaikreuzer
added
the
enhancement
|
@Hilbrand Just as a reminder: Please don't forget to set the enhancement or bug label on PRs when merging. 😄 |
kaikreuzer
changed the title
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…nhab#10029) Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…nhab#10029) Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…nhab#10029) Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Höhn stefan@andreaundstefanhoehn.de
New Nanoleaf Shapes support and small fixes
https://openhab.jfrog.io/openhab/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.nanoleaf/3.1.0-SNAPSHOT/