[boschshc] Release v1.1 #10097
Merged
[boschshc] Release v1.1 #10097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y values all other QuantityTypes in bindingcode are fine Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
Replaced the SHC occurrences with Smart Home, to avoid technical names. Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
… offline Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
… of the previous long polling http request This might be the reason why the subscribe request does never finish or finishes with a timeout Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
…ot get timeout from HTTP client Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
We need to try to reconnect again and again (with 15 seconds between the requests) as the controller may have been restarted (update, manual restart,...). This is already done by the initial access, so I reuse that mechanism. Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org> Co-authored-by: Gerd Zanker <gerd.zanker@web.de>
…out failed long polling Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
… is handled now Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
each HTTP request will use now the defined "avp-version=2.1" for request to the smart home controller Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
removed the old static version string access OSGi bundle version information instead Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
- added isOnline check and isAccessPossible now failed in case HTTPStatus is an error - same HTTPStatus check done to all blocking send() request calls - using i18n strings for all bridge updateStatus calls - skipped the 'controller' and use only 'Bosch Smart Home' in descriptions - added more @nullable annotations Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
Hilbrand
added
bug
cpmeister
requested changes
Feb 8, 2021
...hshc/src/main/java/org/openhab/binding/boschshc/internal/devices/bridge/BoschHttpClient.java
Show resolved
Hide resolved
bundles/org.openhab.binding.boschshc/src/main/resources/OH-INF/i18n/boschshc.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
cpmeister
approved these changes
Feb 13, 2021
cpmeister
removed
the
bug
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
* openhab#72 changed use units of measure for the twinguard humidity and purity values all other QuantityTypes in bindingcode are fine * openhab#77 changed title of binding to Bosch Smart Home Replaced the SHC occurrences with Smart Home, to avoid technical names. * openhab#62 Try to restart long polling when it fails before taking the thing offline * openhab#62 Run subscribe request on a new thread instead of using the thread of the previous long polling http request This might be the reason why the subscribe request does never finish or finishes with a timeout * openhab#74 Run the whole long polling response handling in a new thread to not get timeout from HTTP client * openhab#74 Schedule initial access when long polling fails unexpected We need to try to reconnect again and again (with 15 seconds between the requests) as the controller may have been restarted (update, manual restart,...). This is already done by the initial access, so I reuse that mechanism. * Use direct formatting of logger.trace instead of String.format * openhab#76 Use i18n texts instead of raw translations for status messages about failed long polling * openhab#76 Use logger.debug instead of logger.warn for long poll error as it is handled now * openhab#78 defined api-version each HTTP request will use now the defined "avp-version=2.1" for request to the smart home controller * logging bundle version removed the old static version string access OSGi bundle version information instead * openhab#75 improved initial access - added isOnline check and isAccessPossible now failed in case HTTPStatus is an error - same HTTPStatus check done to all blocking send() request calls - using i18n strings for all bridge updateStatus calls - skipped the 'controller' and use only 'Bosch Smart Home' in descriptions - added more @nullable annotations * added newline Signed-off-by: Gerd Zanker <gerd.zanker@web.de> Signed-off-by: Christian Oeing <christian.oeing@slashgames.org> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* openhab#72 changed use units of measure for the twinguard humidity and purity values all other QuantityTypes in bindingcode are fine * openhab#77 changed title of binding to Bosch Smart Home Replaced the SHC occurrences with Smart Home, to avoid technical names. * openhab#62 Try to restart long polling when it fails before taking the thing offline * openhab#62 Run subscribe request on a new thread instead of using the thread of the previous long polling http request This might be the reason why the subscribe request does never finish or finishes with a timeout * openhab#74 Run the whole long polling response handling in a new thread to not get timeout from HTTP client * openhab#74 Schedule initial access when long polling fails unexpected We need to try to reconnect again and again (with 15 seconds between the requests) as the controller may have been restarted (update, manual restart,...). This is already done by the initial access, so I reuse that mechanism. * Use direct formatting of logger.trace instead of String.format * openhab#76 Use i18n texts instead of raw translations for status messages about failed long polling * openhab#76 Use logger.debug instead of logger.warn for long poll error as it is handled now * openhab#78 defined api-version each HTTP request will use now the defined "avp-version=2.1" for request to the smart home controller * logging bundle version removed the old static version string access OSGi bundle version information instead * openhab#75 improved initial access - added isOnline check and isAccessPossible now failed in case HTTPStatus is an error - same HTTPStatus check done to all blocking send() request calls - using i18n strings for all bridge updateStatus calls - skipped the 'controller' and use only 'Bosch Smart Home' in descriptions - added more @nullable annotations * added newline Signed-off-by: Gerd Zanker <gerd.zanker@web.de> Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* openhab#72 changed use units of measure for the twinguard humidity and purity values all other QuantityTypes in bindingcode are fine * openhab#77 changed title of binding to Bosch Smart Home Replaced the SHC occurrences with Smart Home, to avoid technical names. * openhab#62 Try to restart long polling when it fails before taking the thing offline * openhab#62 Run subscribe request on a new thread instead of using the thread of the previous long polling http request This might be the reason why the subscribe request does never finish or finishes with a timeout * openhab#74 Run the whole long polling response handling in a new thread to not get timeout from HTTP client * openhab#74 Schedule initial access when long polling fails unexpected We need to try to reconnect again and again (with 15 seconds between the requests) as the controller may have been restarted (update, manual restart,...). This is already done by the initial access, so I reuse that mechanism. * Use direct formatting of logger.trace instead of String.format * openhab#76 Use i18n texts instead of raw translations for status messages about failed long polling * openhab#76 Use logger.debug instead of logger.warn for long poll error as it is handled now * openhab#78 defined api-version each HTTP request will use now the defined "avp-version=2.1" for request to the smart home controller * logging bundle version removed the old static version string access OSGi bundle version information instead * openhab#75 improved initial access - added isOnline check and isAccessPossible now failed in case HTTPStatus is an error - same HTTPStatus check done to all blocking send() request calls - using i18n strings for all bridge updateStatus calls - skipped the 'controller' and use only 'Bosch Smart Home' in descriptions - added more @nullable annotations * added newline Signed-off-by: Gerd Zanker <gerd.zanker@web.de> Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Hope all of you had a good start into the new year :)
We prepared a patch version of our binding, as there were some severe bugs in it which stopped the binding to work after 24 hours and after a restart of the controller.
Plus we use the new version to be up-to-date with the Bosch Rest API (v2.1) and fixed two minor issues (binding title and units used).
Here is the list of changes in this version: