Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[androiddebugbridge] check device awake state and minor fixes #10106

Merged
merged 2 commits into from Feb 9, 2021
Merged

[androiddebugbridge] check device awake state and minor fixes #10106

merged 2 commits into from Feb 9, 2021

Conversation

GiviMAD
Copy link
Member

@GiviMAD GiviMAD commented Feb 8, 2021

Signed-off-by: Miguel miguelwork92@gmail.com

The binding logs a lot of timeout warnings because it keeps trying to refresh the channels when the android device is not awake, as far as I saw some services stop working when the device go to sleep. This pr aims to fix this by checking that the device is awake before refreshing other channels and also fixes the screen-state channel which was not working correctly.

Signed-off-by: Miguel <miguelwork92@gmail.com>
Signed-off-by: Miguel <miguelwork92@gmail.com>
@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Feb 8, 2021
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit f8d5ae0 into openhab:main Feb 9, 2021
@cpmeister cpmeister added this to the 3.1 milestone Feb 9, 2021
@GiviMAD GiviMAD deleted the androiddebugbridge branch March 13, 2021 09:45
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…b#10106)

* check device awake state and minor fixes
* avoid update awake channel when not linked

Signed-off-by: Miguel <miguelwork92@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…b#10106)

* check device awake state and minor fixes
* avoid update awake channel when not linked

Signed-off-by: Miguel <miguelwork92@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…b#10106)

* check device awake state and minor fixes
* avoid update awake channel when not linked

Signed-off-by: Miguel <miguelwork92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants