[hdpowerview] Eliminate nightly crash dump #10118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
changed the title
cpmeister
requested changes
Feb 14, 2021
...dpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/HDPowerViewWebTargets.java
Outdated
Show resolved
Hide resolved
...binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/HDPowerViewJUnitTests.java
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
cpmeister
requested changes
Feb 14, 2021
...dpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/HDPowerViewWebTargets.java
Outdated
Show resolved
Hide resolved
...dpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/HDPowerViewWebTargets.java
Outdated
Show resolved
Hide resolved
...dpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/HDPowerViewWebTargets.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
cpmeister
approved these changes
Feb 16, 2021
|
@cpmeister many thanks Connor |
K4ntir4n
pushed a commit
to K4ntir4n/openhab-addons
that referenced
this pull request
Feb 17, 2021
* [hdpowerview] refactor from jax-rs to http client * [hdpowerview] adopt proposals of code reviewer * [hdpowerview] adopt additional proposals of code reviewer * [hdpowerview] provide exception class name Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
* [hdpowerview] refactor from jax-rs to http client * [hdpowerview] adopt proposals of code reviewer * [hdpowerview] adopt additional proposals of code reviewer * [hdpowerview] provide exception class name Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
wborn
changed the title
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* [hdpowerview] refactor from jax-rs to http client * [hdpowerview] adopt proposals of code reviewer * [hdpowerview] adopt additional proposals of code reviewer * [hdpowerview] provide exception class name Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [hdpowerview] refactor from jax-rs to http client * [hdpowerview] adopt proposals of code reviewer * [hdpowerview] adopt additional proposals of code reviewer * [hdpowerview] provide exception class name Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The HDPowerView hub goes briefly offline every night in the small hours for house-keeping. The binding detects this behaviour and (since it is by design) does not log this as an error.
In OH2, the binding used its own Jersey JAX-RS client, so the binding could detect and handle this offline state fully within its own code. But in OH3 the binding was migrated via PR 9224 to use the Apache CXF JAX-RS client of the OH core instead. This means that the OH core sees the offline condition before the binding can handle it; so the Apache CXF code of the core writes a crash dump into the log every night.
This was reported as an issue here #10057
Solution
This PR migrates the binding from using the Apache CXF JAX-RS client of the OH core to using the Jetty HTTP client of the OH core instead. This means that the housekeeping offline state of the hub can once more be caught and handled softly by the binding.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch