Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mpd] fix invalid volume #10166

Merged
merged 1 commit into from Feb 17, 2021
Merged

Conversation

stefanroellin
Copy link
Contributor

Fixes #10142.

Signed-off-by: Stefan Roellin stefan@roellin-baumann.ch

@J-N-K
Copy link
Member

J-N-K commented Feb 15, 2021

Usually copying the work of other should be honored with an Also-By sign-off.

Fixes openhab#10142.

Signed-off-by: Stefan Roellin <stefan@roellin-baumann.ch>
Also-by: Jan N. Klug <jan.n.klug@rub.de>
@stefanroellin
Copy link
Contributor Author

Sorry - didn't know. Fixed. Thanks for your work!
And: it is a pity you didn't submit your fix to the main repository.

@Hilbrand Hilbrand added the bug An unexpected problem or unintended behavior of an add-on label Feb 17, 2021
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit 8a4b87e into openhab:main Feb 17, 2021
@Hilbrand Hilbrand added this to the 3.1 milestone Feb 17, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
Fixes openhab#10142.

Signed-off-by: Stefan Roellin <stefan@roellin-baumann.ch>
Also-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Fixes openhab#10142.

Signed-off-by: Stefan Roellin <stefan@roellin-baumann.ch>
Also-by: Jan N. Klug <jan.n.klug@rub.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Fixes openhab#10142.

Signed-off-by: Stefan Roellin <stefan@roellin-baumann.ch>
Also-by: Jan N. Klug <jan.n.klug@rub.de>
@stefanroellin stefanroellin deleted the mpd-fix-invalid-volume branch October 21, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MPD] doesn't work with external mpd player
3 participants