Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miio] add support for cgllc.airm.cgdn1 Qingping Air Monitor Lite #10182

Merged
merged 7 commits into from Apr 10, 2021
Merged

[miio] add support for cgllc.airm.cgdn1 Qingping Air Monitor Lite #10182

merged 7 commits into from Apr 10, 2021

Conversation

marcelrv
Copy link
Contributor

close #10152

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

@marcelrv
[miio] add support for cgllc.airm.cgdn1 Qingping Air Monitor Lite
279aec3 
close openhab#10152

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged labels Feb 16, 2021
@marcelrv marcelrv removed the work in progress A PR that is not yet ready to be merged label Feb 25, 2021
@marcelrv
Improve readme
466f82e 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
cpmeister
cpmeister requested changes Feb 25, 2021
View reviewed changes
bundles/org.openhab.binding.miio/src/main/resources/database/cgllc.airm.cgdn1-miot.json Outdated
"piid": 3,
"friendlyName": "Battery - Voltage",
"channel": "voltage",
"type": "Number",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": "Number",
"type": "Number:ElectricPotential",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeberlin123 For this, can you confirm what you see as value in the screen of the app and in the channel.
I expect this to be mV, but would be good to confirm

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can confirm. The channel shows the values as mV

bundles/org.openhab.binding.miio/src/main/resources/database/cgllc.airm.cgdn1-miot.json Outdated
"piid": 2,
"friendlyName": "Settings - Start Time",
"channel": "start_time",
"type": "Number",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be a time unit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeberlin123 can you confirm what you are seeing for this channel as value and how it translates in the mihome app.
Than we can determine what is indeed it is (e.g. the time until it switches on/off or a date/time sort of thing.

The spec does not hint anything

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find something like start time in the mi home app. If I use item type number I get 0.0 and if I use date time I get NULL. Do have another hint for me?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took out this property... if we can't find it in the app and it is unknown what it does, it is useless.

bundles/org.openhab.binding.miio/src/main/resources/database/cgllc.airm.cgdn1-miot.json Outdated
"piid": 5,
"friendlyName": "Environment - PM10 Density",
"channel": "pm10_density",
"type": "Number",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": "Number",
"type": "Number:Density",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, Done.

bundles/org.openhab.binding.miio/src/main/resources/database/cgllc.airm.cgdn1-miot.json Outdated
"piid": 4,
"friendlyName": "Environment - PM2 5 Density",
"channel": "pm2_5_density",
"type": "Number",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": "Number",
"type": "Number:Density",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, Done.

@marcelrv
[miio] improve qty types
4d2e434 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
fwolter
fwolter requested changes Apr 9, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You code doesn't compile as CloudLoginDTO uses the wrong NotNull import:
import org.jetbrains.annotations.NotNull;

@marcelrv
Copy link
Contributor Author

marcelrv commented Apr 9, 2021

You code doesn't compile as CloudLoginDTO uses the wrong NotNull import:
import org.jetbrains.annotations.NotNull;

This was changed some time ago.. should no longer be the case

fwolter
fwolter approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There are some checkstyle warnings in the binding, which can be easily fixed. You could take a look at target/code-analysis/report.html.

@fwolter fwolter merged commit 5ba6451 into openhab:main Apr 10, 2021
@fwolter fwolter added this to the 3.1 milestone Apr 10, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@marcelrv @themillhousegroup
[miio] add support for cgllc.airm.cgdn1 Qingping Air Monitor Lite (op…
dc6fdf3 
…enhab#10182)

* [miio] add support for cgllc.airm.cgdn1 Qingping Air Monitor Lite

close openhab#10152

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] remove expiremental

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* Improve readme

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] improve qty types

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] remove unknown element

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@marcelrv @computergeek1507
[miio] add support for cgllc.airm.cgdn1 Qingping Air Monitor Lite (op…
b2de7ca 
…enhab#10182)

* [miio] add support for cgllc.airm.cgdn1 Qingping Air Monitor Lite

close openhab#10152

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] remove expiremental

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* Improve readme

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] improve qty types

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] remove unknown element

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@marcelrv @thinkingstone
[miio] add support for cgllc.airm.cgdn1 Qingping Air Monitor Lite (op…
b2650ec 
…enhab#10182)

* [miio] add support for cgllc.airm.cgdn1 Qingping Air Monitor Lite

close openhab#10152

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] remove expiremental

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* Improve readme

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] improve qty types

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] remove unknown element

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv deleted the miio-cgllc.airm.cgdn1 branch December 6, 2021 16:10
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@marcelrv
[miio] add support for cgllc.airm.cgdn1 Qingping Air Monitor Lite (op…
b98809b 
…enhab#10182)

* [miio] add support for cgllc.airm.cgdn1 Qingping Air Monitor Lite

close openhab#10152

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] remove expiremental

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* Improve readme

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] improve qty types

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] remove unknown element

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeberlin123 joeberlin123 joeberlin123 left review comments

@fwolter fwolter fwolter approved these changes

@cpmeister cpmeister Awaiting requested review from cpmeister

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[miio] Please support Qingping Air Monitor Lite (cgllc.airm.cgdn1)
4 participants
@marcelrv @cpmeister @fwolter @joeberlin123