[openwebnet] add support for Energy Meter #10191

aconte80 · 2021-02-17T21:27:57Z

These changes will:

restore support for Energy Meters (formerly "Energy Central Unit" in OH2, for example BTI-F520). Issue #10188 or see community thread.
Improvement: handle readed data with Unit of Measure (Watt)

sync with official repo

Signed-off-by: Andrea Conte <andrea@conte.com> Signed-off-by: Conte Andrea <andrea@conte.com>

mvalla · 2021-02-25T22:40:49Z

this PR will also close #10242 by using version 0.4.0 of the openwebnet4j lib (see: https://github.com/mvalla/openwebnet4j/releases/tag/0.4.0).

fwolter

Did you modify the images intentionally?

bundles/org.openhab.binding.openwebnet/README.md

...ding.openwebnet/src/main/java/org/openhab/binding/openwebnet/OpenWebNetBindingConstants.java

...openwebnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetBridgeHandler.java

...openwebnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetEnergyHandler.java

bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/BusEnergyMeter.xml

bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml

update code to 14/03

Signed-off-by: Conte Andrea <andrea@conte.com>

...openwebnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetEnergyHandler.java

Signed-off-by: Conte Andrea <andrea@conte.com>

fwolter · 2021-03-16T18:02:53Z

@mvalla The 0.4.0 version is not found when building this PR.

mvalla · 2021-03-16T20:10:05Z

@mvalla The 0.4.0 version is not found when building this PR.

@fwolter Very strange: actually all versions of the lib are now returning "403 Fobidden".
For example: https://jcenter.bintray.com/com/github/openwebnet4j/openwebnet4j/0.3.4/

Maybe it's a temporary problem, hopefully not related to the soon to be Bintray/JCenter shutdown

kaikreuzer · 2021-03-16T20:52:02Z

Maybe it's a temporary problem, hopefully not related to the soon to be Bintray/JCenter shutdown

It is related to it. I have started working on openhab/openhab-distro#1256 and this requires us to not use any dependencies from JCenter anymore.

@mvalla Could you publish the lib to Maven Central instead? This seems to be the only working option on the long run.
As long as Bintray is still available, you can use Bintray's "Push to Maven Central" feature to do it without too much effort.

mvalla · 2021-03-17T09:24:20Z

it looks like a double problem.

artifacts are not accessible anymore: they all return 403 Forbidden. After a quick check this applies to other artifacts as well - just click on one of the files. I have seen some service shortage announced on JCenter, but now declared as solved. This is strange as they promised existing artifacts will be served until 2022:

After this date JCenter repository will still resolve artifacts, but end users should migrate to the canonical repo (e.g. Java packages should be retrieved from Maven Central). On Feb 1st, 2022 JCenter will only resolve artifacts for Artifactory clients.

migration away from JCenter by @kaikreuzer : yes of course I would like to move the lib to Maven Central, but it's not a 1-click process and the quicker "Push to Maven Central" does not work atm, maybe because of the 403 Forbidden error. I will have to go through the Sonatype approval process, and if everybody is migrating now they will be surely very busy (and slow).

Did you have similar problems with other artifacts used by OH and not available anymore?

kaikreuzer · 2021-03-17T19:12:29Z

Yes, I have similar problems with other artifacts and I am looking for an alternative source for each. If none can be found, I temporarily upload them to our Artifactory. I just did so with openwebnet4j as well, but I uses openwebnet4j as its group id.
Only noticed now that you defined the group id to be com.github.openwebnet4j. Why this, this is not at Github library, is it? I strongly suggest to change the groupId because otherwise you'll anyhow not be allowed to bring it to Maven Central.

kaikreuzer · 2021-03-17T19:13:07Z

bundles/org.openhab.binding.openwebnet/pom.xml

@@ -23,7 +23,7 @@
    <dependency>
      <groupId>com.github.openwebnet4j</groupId>


Suggested change

<groupId>com.github.openwebnet4j</groupId>

<groupId>openwebnet4j</groupId>

This should make it resolve from our Artifactory for now.

mvalla · 2021-03-17T21:45:36Z

Thanks @kaikreuzer for hosting the artifact on OH Artifactory : it's a shame JCenter apparently is offline even before the planned date!

Only noticed now that you defined the group id to be com.github.openwebnet4j. Why this, this is not at Github library, is it? I strongly suggest to change the groupId because otherwise you'll anyhow not be allowed to bring it to Maven Central.

Actually the policy is:

you must choose a groupId for a domain that you own, or for which you are the designated maintainer on behalf of the owner. In the case of a GitHub groupId (io.github.username), this will be immediately verified provided your project URL matches the requested groupId.

that is why I used com.github.openwebnet4j in the first place and I also created the github group openwebnet4j to migrate in the future.

So to summarize: I will move to Maven Central keeping com.github.openwebnet4j but it takes time...

kaikreuzer · 2021-03-18T16:10:09Z

that is why I used com.github.openwebnet4j in the first place

If you read carefully, it says that the groupId must be io.github.mvalla. Maven Central seems to be fine with using com instead of io as well, but as this is not specified in their guideline, I'd go for io, since this is what is used for Github pages (and hence it qualifies as a domain name that is under your control).

kaikreuzer · 2021-03-19T10:23:14Z

@mvalla I have uploaded version 0.4.0 to our Artifactory under the current groupId, so that it can now be resolved.
Please adapt the groupId for future releases, though.
The build now fails with spotless errors that you'll need to fix as it seems.

mvalla · 2021-03-20T10:01:44Z

@mvalla I have uploaded version 0.4.0 to our Artifactory under the current groupId, so that it can now be resolved.
Please adapt the groupId for future releases, though.
The build now fails with spotless errors that you'll need to fix as it seems.

thanks @kaikreuzer for publishing under OH Artifactory with the current groupId: that is indeed the cleanest temporary solution.
JCenter is still returning 403 Forbidden (for past releases as well).
I will open a new ticket to publish via OSSRH to Maven Central with new groupId io.github.openwebnet4j.

I leave to @aconte80 the fixes for the spotless errors.

kaikreuzer · 2021-03-20T12:46:35Z

I leave to @aconte80 the fixes for the spotless errors.

Ah, right, I didn't notice that this PR wasn't from you :-)

Signed-off-by: Conte Andrea <andrea@conte.com>

aconte80 · 2021-03-21T18:38:15Z

@kaikreuzer @fwolter I've fixed the spotless error.

kaikreuzer

Perfect, thank you all!

mvalla · 2021-03-27T10:30:09Z

@fwolter @wborn please add links to issues #10242 and #10188 that are closed by this PR

wborn · 2021-03-27T10:34:56Z

They are linked now @mvalla. :-)

Signed-off-by: Andrea Conte <andrea@conte.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>

Signed-off-by: Andrea Conte <andrea@conte.com>

aconte80 added 2 commits February 15, 2021 16:41

Merge pull request #1 from openhab/main

2bb6e38

sync with official repo

add support for Energy Management openhab#10189

0a89dc5

Signed-off-by: Andrea Conte <andrea@conte.com> Signed-off-by: Conte Andrea <andrea@conte.com>

aconte80 force-pushed the oh3.1-own-energy branch from ac3d640 to 0a89dc5 Compare February 17, 2021 21:34

aconte80 closed this Feb 18, 2021

aconte80 reopened this Feb 18, 2021

mvalla mentioned this pull request Feb 25, 2021

[openwebnet] OPEN password nonce with less than 7 digits not supported #10242

Closed

fwolter requested changes Mar 13, 2021

View reviewed changes

aconte80 added 3 commits March 14, 2021 18:23

Merge pull request #2 from openhab/main

d93eb7b

update code to 14/03

fixed code-review suggestions

d3d270a

Signed-off-by: Conte Andrea <andrea@conte.com>

fixed code-review suggestions #2

f4cbb11

Signed-off-by: Conte Andrea <andrea@conte.com>

aconte80 requested a review from fwolter March 14, 2021 18:24

fwolter requested changes Mar 15, 2021

View reviewed changes

...openwebnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetEnergyHandler.java Outdated Show resolved Hide resolved

removed initialize() and dispose() override

b247b83

Signed-off-by: Conte Andrea <andrea@conte.com>

kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Mar 17, 2021

kaikreuzer reviewed Mar 17, 2021

View reviewed changes

kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Mar 18, 2021

redo mvn:spotless apply

824a939

Signed-off-by: Conte Andrea <andrea@conte.com>

aconte80 force-pushed the oh3.1-own-energy branch from 11239c1 to 824a939 Compare March 21, 2021 10:10

aconte80 requested review from kaikreuzer and fwolter March 21, 2021 18:37

kaikreuzer approved these changes Mar 21, 2021

View reviewed changes

kaikreuzer merged commit 2e770a3 into openhab:main Mar 21, 2021

wborn added this to the 3.1 milestone Mar 21, 2021

mvalla mentioned this pull request Mar 27, 2021

[openwebnet] add support for Energy Management (WHO=18) #10188

Closed

kaikreuzer added the enhancement An enhancement or new feature for an existing add-on label Apr 2, 2021

themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021

[openwebnet] add support for Energy Meter (openhab#10191)

918ce70

Signed-off-by: Andrea Conte <andrea@conte.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>

computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021

[openwebnet] add support for Energy Meter (openhab#10191)

d708caa

Signed-off-by: Andrea Conte <andrea@conte.com>

thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021

[openwebnet] add support for Energy Meter (openhab#10191)

4a85940

Signed-off-by: Andrea Conte <andrea@conte.com>

marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022

[openwebnet] add support for Energy Meter (openhab#10191)

4641566

Signed-off-by: Andrea Conte <andrea@conte.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[openwebnet] add support for Energy Meter #10191

[openwebnet] add support for Energy Meter #10191

aconte80 commented Feb 17, 2021 •

edited by wborn

mvalla commented Feb 25, 2021

fwolter left a comment

fwolter commented Mar 16, 2021

mvalla commented Mar 16, 2021

kaikreuzer commented Mar 16, 2021

mvalla commented Mar 17, 2021

kaikreuzer commented Mar 17, 2021

kaikreuzer Mar 17, 2021

mvalla commented Mar 17, 2021

kaikreuzer commented Mar 18, 2021

kaikreuzer commented Mar 19, 2021

mvalla commented Mar 20, 2021

kaikreuzer commented Mar 20, 2021

aconte80 commented Mar 21, 2021

kaikreuzer left a comment

mvalla commented Mar 27, 2021 •

edited

wborn commented Mar 27, 2021

		@@ -23,7 +23,7 @@
		<dependency>
		<groupId>com.github.openwebnet4j</groupId>

	<groupId>com.github.openwebnet4j</groupId>
	<groupId>openwebnet4j</groupId>

[openwebnet] add support for Energy Meter #10191

[openwebnet] add support for Energy Meter #10191

Conversation

aconte80 commented Feb 17, 2021 • edited by wborn

mvalla commented Feb 25, 2021

fwolter left a comment

Choose a reason for hiding this comment

fwolter commented Mar 16, 2021

mvalla commented Mar 16, 2021

kaikreuzer commented Mar 16, 2021

mvalla commented Mar 17, 2021

kaikreuzer commented Mar 17, 2021

kaikreuzer Mar 17, 2021

Choose a reason for hiding this comment

mvalla commented Mar 17, 2021

kaikreuzer commented Mar 18, 2021

kaikreuzer commented Mar 19, 2021

mvalla commented Mar 20, 2021

kaikreuzer commented Mar 20, 2021

aconte80 commented Mar 21, 2021

kaikreuzer left a comment

Choose a reason for hiding this comment

mvalla commented Mar 27, 2021 • edited

wborn commented Mar 27, 2021

aconte80 commented Feb 17, 2021 •

edited by wborn

mvalla commented Mar 27, 2021 •

edited