[yeelight] Add mono4 and strip6 #10222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding additional models to deviceType enum - "mono4" and "strip6" (please note this is not a typo in "strip6" - six is at the end and without 'e') - based on the analysis of the debug info those new models are not being recognised by Yeelight binding in OH3 and as a result the bulb or the led stripe is constantly showing offline despite correct device id.
fwolter
approved these changes
Mar 13, 2021
There was a problem hiding this comment.
LGTM, applying the small patch exception.
You need to sign-off your commits. See https://www.openhab.org/docs/developer/contributing.html#sign-your-work The necessary commands are listed when you click on "Details" at the DCO check below.
fwolter
changed the title
arjanmels
pushed a commit
to arjanmels/openhab2-addons
that referenced
this pull request
Mar 14, 2021
Adding additional models to deviceType enum - "mono4" and "strip6" (please note this is not a typo in "strip6" - six is at the end and without 'e') - based on the analysis of the debug info those new models are not being recognised by Yeelight binding in OH3 and as a result the bulb or the led stripe is constantly showing offline despite correct device id.
kaikreuzer
added
the
enhancement
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
Adding additional models to deviceType enum - "mono4" and "strip6" (please note this is not a typo in "strip6" - six is at the end and without 'e') - based on the analysis of the debug info those new models are not being recognised by Yeelight binding in OH3 and as a result the bulb or the led stripe is constantly showing offline despite correct device id. Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
Adding additional models to deviceType enum - "mono4" and "strip6" (please note this is not a typo in "strip6" - six is at the end and without 'e') - based on the analysis of the debug info those new models are not being recognised by Yeelight binding in OH3 and as a result the bulb or the led stripe is constantly showing offline despite correct device id.
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Adding additional models to deviceType enum - "mono4" and "strip6" (please note this is not a typo in "strip6" - six is at the end and without 'e') - based on the analysis of the debug info those new models are not being recognised by Yeelight binding in OH3 and as a result the bulb or the led stripe is constantly showing offline despite correct device id.
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Adding additional models to deviceType enum - "mono4" and "strip6" (please note this is not a typo in "strip6" - six is at the end and without 'e') - based on the analysis of the debug info those new models are not being recognised by Yeelight binding in OH3 and as a result the bulb or the led stripe is constantly showing offline despite correct device id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional models to deviceType enum - "mono4" and "strip6" (please note this is not a typo in "strip6" - six is at the end and without 'e') - based on the analysis of the debug info those new models are not being recognised by Yeelight binding in OH3 and as a result the bulb or the led stripe is constantly showing offline despite correct device id.