[magentatv] Adapt to new Telekom OAuth flow (required to retrieve the userId) #10267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markus7017
added
the
enhancement
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017
force-pushed
the
magentatv_3.1-1
branch
from
aca4a09
to
f72d99e
Compare
markus7017
added
enhancement
markus7017
requested review from
Hilbrand,
fwolter and
kaikreuzer
and removed request for
Hilbrand
|
@openhab/add-ons-maintainers Could someone pick-up this small PR? Telekom changed the auth flow, so new users are no longer able to signin with the current version included with the distro. This PR fixes the problem and should be easy to review |
kaikreuzer
requested changes
Mar 13, 2021
...magentatv/src/main/java/org/openhab/binding/magentatv/internal/handler/MagentaTVHandler.java
Outdated
Show resolved
Hide resolved
...g.magentatv/src/main/java/org/openhab/binding/magentatv/internal/network/MagentaTVOAuth.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.magentatv/src/main/resources/OH-INF/binding/binding.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.magentatv/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
Signed-off-by: Markus Michels <markus7017@gmail.com>
|
@kaikreuzer review changes applied |
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
… userId) (openhab#10267) Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
… userId) (openhab#10267) Signed-off-by: Markus Michels <markus7017@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
… userId) (openhab#10267) Signed-off-by: Markus Michels <markus7017@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
… userId) (openhab#10267) Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapted to the new OAuth flow, current version is not able to retrieve the userId from the authenticated account.