[somfytahoma] Setting of channels at init + UoM for channels #10300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
somfytahoma_initchannels
branch
from
70c6904
to
ec40f15
Compare
octa22
reviewed
Mar 9, 2021
.../main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaBaseThingHandler.java
Show resolved
Hide resolved
octa22
requested changes
Mar 9, 2021
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
@octa22 : can you please approve now? |
octa22
approved these changes
Mar 12, 2021
|
@openhab/add-ons-maintainers : is it possible to have a review & merge of this PR which is now validated by the binding author ? |
fwolter
requested changes
Mar 13, 2021
.../main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaBaseThingHandler.java
Outdated
Show resolved
Hide resolved
.../main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaBaseThingHandler.java
Outdated
Show resolved
Hide resolved
.../main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaBaseThingHandler.java
Show resolved
Hide resolved
Signed-off-by: Laurent Ganier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
arjanmels
pushed a commit
to arjanmels/openhab2-addons
that referenced
this pull request
Mar 14, 2021
…#10300) Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
added
the
enhancement
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…#10300) Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
…#10300) Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…#10300) Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…#10300) Fix openhab#10291 Fix openhab#10285 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10291
Fix #10285
Signed-off-by: Laurent Garnier lg.hc@free.fr