[miio] Fix viomi's battary_life property #10394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viomi's property battery life seems to have a weird typo. The property's real name is `battary_life` instead of `battery_life`. Using the wrong name `battery_life` makes the other properties in the batch to be undefined: `"run_state","mode","err_state","battary_life","box_type"` The correct name `battary_life` is already used in other projects like https://github.com/rytilahti/python-miio/blob/master/miio/viomivacuum.py#L316 or https://github.com/Hypfer/Valetudo/blob/0bed81ab4f0ddccdad044ce805dda3af8736eb96/lib/robots/viomi/ViomiValetudoRobot.js#L254 Signed-off-by: Antonio Tapiador del Dujo <atd@singularities.org>
kaikreuzer
approved these changes
Mar 31, 2021
kaikreuzer
added
the
bug
Daniel-42
pushed a commit
to Daniel-42/openhab-addons
that referenced
this pull request
Apr 6, 2021
Viomi's property battery life seems to have a weird typo. The property's real name is `battary_life` instead of `battery_life`. Using the wrong name `battery_life` makes the other properties in the batch to be undefined: `"run_state","mode","err_state","battary_life","box_type"` The correct name `battary_life` is already used in other projects like https://github.com/rytilahti/python-miio/blob/master/miio/viomivacuum.py#L316 or https://github.com/Hypfer/Valetudo/blob/0bed81ab4f0ddccdad044ce805dda3af8736eb96/lib/robots/viomi/ViomiValetudoRobot.js#L254 Signed-off-by: Antonio Tapiador del Dujo <atd@singularities.org>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
Viomi's property battery life seems to have a weird typo. The property's real name is `battary_life` instead of `battery_life`. Using the wrong name `battery_life` makes the other properties in the batch to be undefined: `"run_state","mode","err_state","battary_life","box_type"` The correct name `battary_life` is already used in other projects like https://github.com/rytilahti/python-miio/blob/master/miio/viomivacuum.py#L316 or https://github.com/Hypfer/Valetudo/blob/0bed81ab4f0ddccdad044ce805dda3af8736eb96/lib/robots/viomi/ViomiValetudoRobot.js#L254 Signed-off-by: Antonio Tapiador del Dujo <atd@singularities.org> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
Viomi's property battery life seems to have a weird typo. The property's real name is `battary_life` instead of `battery_life`. Using the wrong name `battery_life` makes the other properties in the batch to be undefined: `"run_state","mode","err_state","battary_life","box_type"` The correct name `battary_life` is already used in other projects like https://github.com/rytilahti/python-miio/blob/master/miio/viomivacuum.py#L316 or https://github.com/Hypfer/Valetudo/blob/0bed81ab4f0ddccdad044ce805dda3af8736eb96/lib/robots/viomi/ViomiValetudoRobot.js#L254 Signed-off-by: Antonio Tapiador del Dujo <atd@singularities.org>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Viomi's property battery life seems to have a weird typo. The property's real name is `battary_life` instead of `battery_life`. Using the wrong name `battery_life` makes the other properties in the batch to be undefined: `"run_state","mode","err_state","battary_life","box_type"` The correct name `battary_life` is already used in other projects like https://github.com/rytilahti/python-miio/blob/master/miio/viomivacuum.py#L316 or https://github.com/Hypfer/Valetudo/blob/0bed81ab4f0ddccdad044ce805dda3af8736eb96/lib/robots/viomi/ViomiValetudoRobot.js#L254 Signed-off-by: Antonio Tapiador del Dujo <atd@singularities.org>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Viomi's property battery life seems to have a weird typo. The property's real name is `battary_life` instead of `battery_life`. Using the wrong name `battery_life` makes the other properties in the batch to be undefined: `"run_state","mode","err_state","battary_life","box_type"` The correct name `battary_life` is already used in other projects like https://github.com/rytilahti/python-miio/blob/master/miio/viomivacuum.py#L316 or https://github.com/Hypfer/Valetudo/blob/0bed81ab4f0ddccdad044ce805dda3af8736eb96/lib/robots/viomi/ViomiValetudoRobot.js#L254 Signed-off-by: Antonio Tapiador del Dujo <atd@singularities.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viomi's property battery life seems to have a weird typo. The property's real name is
battary_lifeinstead ofbattery_life. Using the wrong namebattery_lifemakes the other properties in the batch to be undefined:"run_state","mode","err_state","battary_life","box_type"The correct name
battary_lifeis already used in other projects like https://github.com/rytilahti/python-miio/blob/master/miio/viomivacuum.py#L316 or https://github.com/Hypfer/Valetudo/blob/0bed81ab4f0ddccdad044ce805dda3af8736eb96/lib/robots/viomi/ViomiValetudoRobot.js#L254