[neohub] Quality improvements #10522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
This reverts commit 022513e.
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
the
enhancement
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
fwolter
requested changes
Apr 16, 2021
....openhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoHubHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
|
Many thanks. |
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
* [neohub] eliminate once in a blue moon fin-ack fin-ack issues Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * Revert "[neohub] eliminate once in a blue moon fin-ack fin-ack issues" This reverts commit 022513e. * [neohub] extra hub properties; hub id in logs (help for multiple hubs) Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] run spotless Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] getFirmwareVersion returns null for unknown Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] api version enum; tweaked logging Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] fix mvn warning Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] cosmetic for diff Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] device info property, and comments Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] tweaks to fin-ack sequence Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] eliminate irrelevant compiler warnings, and live test errors Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] avert merge conflict with openhab#10525 Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] apply changes in anticipation of reviewer approval Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
* [neohub] eliminate once in a blue moon fin-ack fin-ack issues Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * Revert "[neohub] eliminate once in a blue moon fin-ack fin-ack issues" This reverts commit 022513e. * [neohub] extra hub properties; hub id in logs (help for multiple hubs) Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] run spotless Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] getFirmwareVersion returns null for unknown Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] api version enum; tweaked logging Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] fix mvn warning Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] cosmetic for diff Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] device info property, and comments Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] tweaks to fin-ack sequence Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] eliminate irrelevant compiler warnings, and live test errors Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] avert merge conflict with openhab#10525 Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] apply changes in anticipation of reviewer approval Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
* [neohub] eliminate once in a blue moon fin-ack fin-ack issues Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * Revert "[neohub] eliminate once in a blue moon fin-ack fin-ack issues" This reverts commit 022513e. * [neohub] extra hub properties; hub id in logs (help for multiple hubs) Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] run spotless Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] getFirmwareVersion returns null for unknown Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] api version enum; tweaked logging Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] fix mvn warning Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] cosmetic for diff Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] device info property, and comments Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] tweaks to fin-ack sequence Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] eliminate irrelevant compiler warnings, and live test errors Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] avert merge conflict with openhab#10525 Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] apply changes in anticipation of reviewer approval Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* [neohub] eliminate once in a blue moon fin-ack fin-ack issues Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * Revert "[neohub] eliminate once in a blue moon fin-ack fin-ack issues" This reverts commit 022513e. * [neohub] extra hub properties; hub id in logs (help for multiple hubs) Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] run spotless Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] getFirmwareVersion returns null for unknown Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] api version enum; tweaked logging Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] fix mvn warning Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] cosmetic for diff Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] device info property, and comments Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] tweaks to fin-ack sequence Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] eliminate irrelevant compiler warnings, and live test errors Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] avert merge conflict with openhab#10525 Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] apply changes in anticipation of reviewer approval Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [neohub] eliminate once in a blue moon fin-ack fin-ack issues Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * Revert "[neohub] eliminate once in a blue moon fin-ack fin-ack issues" This reverts commit 022513e. * [neohub] extra hub properties; hub id in logs (help for multiple hubs) Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] run spotless Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] getFirmwareVersion returns null for unknown Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] api version enum; tweaked logging Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] fix mvn warning Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] cosmetic for diff Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] device info property, and comments Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] tweaks to fin-ack sequence Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] eliminate irrelevant compiler warnings, and live test errors Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] avert merge conflict with openhab#10525 Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [neohub] apply changes in anticipation of reviewer approval Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some assorted quality improvements as follows..
Old: in systems with multiple NeoHub's one could not see which hub was producing logger messages. New: the logger messages now include the ThingUID string.
Old: the logging was too "chatty". New: some logger calls are reduced from [INFO] to [DEBUG], and others now only show [INFO] on a need to know basis (i.e. when something changed)
Old: some important hub properties were not available. New: hub properties have been added for firmware version, api version, and the state of devices on the hub RF mesh network.
Old: very occasionally the hub would go unexpectedly offline. New: minor tweaks have been made in the socket connection closing procedure to reduce the occurrence of such cases.
Old: the JUnit test suite would produce compiler warnings for potential nulls. However these potential nulls are intended and expected parts of the tests. New: SuppressWarnings() annotations have been added so that MVN will ignore potential nulls.
Old: the JUnit test suite would try to make a live test communication with a hub (even if none was present). New: the respective test is disabled if no valid physical hub ip address is provided.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch