Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modbus-e3dc] Fixes wrong E3/DC Emergency Power Possible bit #10536

Merged
merged 1 commit into from Apr 24, 2021

Conversation

2SK135
Copy link
Contributor

@2SK135 2SK135 commented Apr 16, 2021

This fixes the wrong E3/DC Emergency Power Possible bit, reported in issue #10513.
Emergency Power Possible should refer to EMS_AVAILABLE_BIT according to the E3/DC Modbus documentation.

@2SK135
Copy link
Contributor Author

2SK135 commented Apr 16, 2021

@weymann: I kindly ask for your review.

Copy link
Contributor

@weymann weymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, seems to be a copy&paste error. Checked this shortly on my system and now Emergency Power Possible shows the right state.

@cweitkamp cweitkamp added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Apr 22, 2021
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@wborn wborn merged commit 8ba3439 into openhab:main Apr 24, 2021
@wborn wborn added the bug An unexpected problem or unintended behavior of an add-on label Apr 24, 2021
@wborn wborn added this to the 3.1 milestone Apr 24, 2021
@wborn wborn changed the title [modbus-e3dc] Fixes wrong E3/DC Emergency Power Possible bit (#10513) [modbus-e3dc] Fixes wrong E3/DC Emergency Power Possible bit Apr 24, 2021
@2SK135 2SK135 deleted the e3dc-ep-correction branch April 24, 2021 19:22
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…#10536)

Fixes openhab#10513

Signed-off-by: Sebastian <ZweiSK135@t-online.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants