Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nuki] Opener support and discovery #10672
[nuki] Opener support and discovery #10672
Changes from all commits
a1ddf72
107d9b9
c7eed87
0509922
246a97e
42dcfe3
f17bb2f
d6f9c82
3251a39
b1f82fa
4a5ac30
e4a238a
7d5090f
5e7e9e9
8f32b07
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be awesome if you could put these into a table like in the other bindings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I'd like to keep the lists of supported actions and states for some channels and I don't know how to fit them into single table. I looked at other binding and for example Astro has this big multilevel list, other bindings use table but they don't need to specify supported actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could put the command options in a dedicated column and shorten them to e.g. "2=Unlock, 7=Unlatch".
Please note that Actions are something different. See https://www.openhab.org/docs/configuration/actions.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reformatted channel list as a table and put available commands into separate tables