-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nuki] Adds another way to get the nukiId #10677
Conversation
Signed-off-by: TheGreyDiamond <s-einkauf@oest-rs.de>
Signed-off-by: TheGreyDiamond <s-einkauf@oest-rs.de>
Signed-off-by: TheGreyDiamond <s-einkauf@oest-rs.de>
Okay, I need some help with this! Jenkins wasn't helpful, at least for me. What is wrong here? Jenkins output:
|
I made PR #10672 which adds automatic discovery of both Bridge and Smartlock/Opener so if that gets merged you won't need to configure anything, so this might not be needed anymore. |
I guess yes, but does auto discovery work 100% of the time? I had some issues with similar things in the past |
Yes, in fact it won't be possible to manually create smartlock or opener anymore. The binding uses /list endpoint to read state of smartlock, which also contains nukid, so you might as well use it for discovery. If that didnt work, you would not be able to read lock status anyway. |
@TheGreyDiamond Do you agree this is not necessary anymore, then? |
Yes, sure. But just so I learn something, what failed here? |
The spotless plugin didn't like the formatting of the readme file, you can see the error at the end of log file - https://ci.openhab.org/job/PR-openHAB-Addons/4240/console. To fix it run mvn spotless:apply before commiting to make sure all files are formatted properly. |
Thanks! |
Adds an alternate way to retrieve the nukiId
This updates the documentation with another way of retrieving the
nukiId
required for setup. This way is easier and does not require the user to remove the lock.EDIT: Also updates the UI