Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nuki] Adds another way to get the nukiId #10677

Closed
wants to merge 3 commits into from

Conversation

TheGreyDiamond
Copy link

@TheGreyDiamond TheGreyDiamond commented May 12, 2021

Adds an alternate way to retrieve the nukiId

This updates the documentation with another way of retrieving the nukiId required for setup. This way is easier and does not require the user to remove the lock.

EDIT: Also updates the UI

@wborn wborn changed the title [Nuki binding] Adds another way to get the nukiId [nuki] Adds another way to get the nukiId May 12, 2021
Signed-off-by: TheGreyDiamond <s-einkauf@oest-rs.de>
Signed-off-by: TheGreyDiamond <s-einkauf@oest-rs.de>
Signed-off-by: TheGreyDiamond <s-einkauf@oest-rs.de>
@TheGreyDiamond
Copy link
Author

TheGreyDiamond commented May 12, 2021

Okay, I need some help with this! Jenkins wasn't helpful, at least for me. What is wrong here? Jenkins output:

[INFO] 
[INFO] --------< org.openhab.addons.bundles:org.openhab.binding.nuki >---------
[INFO] Building openHAB Add-ons :: Bundles :: Nuki Binding 3.1.0-SNAPSHOT [180/366]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ org.openhab.binding.nuki ---
[INFO] 
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-java) @ org.openhab.binding.nuki ---
[INFO] 
[INFO] --- directory-maven-plugin:0.3.1:directory-of (directories) @ org.openhab.binding.nuki ---
[INFO] Directory of org.openhab.addons:org.openhab.addons.reactor set to: /home/jenkins/jenkins-agent1/workspace/PR-openHAB-Addons@3
[INFO] 
[INFO] --- spotless-maven-plugin:2.0.3:check (codestyle_check) @ org.openhab.binding.nuki ---
[JENKINS] Archiving disabled

@janvyb
Copy link
Contributor

janvyb commented May 12, 2021

I made PR #10672 which adds automatic discovery of both Bridge and Smartlock/Opener so if that gets merged you won't need to configure anything, so this might not be needed anymore.

@TheGreyDiamond
Copy link
Author

I guess yes, but does auto discovery work 100% of the time? I had some issues with similar things in the past

@janvyb
Copy link
Contributor

janvyb commented May 12, 2021

Yes, in fact it won't be possible to manually create smartlock or opener anymore. The binding uses /list endpoint to read state of smartlock, which also contains nukid, so you might as well use it for discovery. If that didnt work, you would not be able to read lock status anyway.

@fwolter
Copy link
Member

fwolter commented May 19, 2021

@TheGreyDiamond Do you agree this is not necessary anymore, then?

@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels May 21, 2021
@TheGreyDiamond
Copy link
Author

Yes, sure. But just so I learn something, what failed here?

@janvyb
Copy link
Contributor

janvyb commented May 21, 2021

Yes, sure. But just so I learn something, what failed here?

The spotless plugin didn't like the formatting of the readme file, you can see the error at the end of log file - https://ci.openhab.org/job/PR-openHAB-Addons/4240/console. To fix it run mvn spotless:apply before commiting to make sure all files are formatted properly.

@TheGreyDiamond
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants