New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pushover] Minor improvements for handling sounds, Fixed SAT findings #10840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Jun 9, 2021
wborn
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
hofingerandi
pushed a commit
to hofingerandi/openhab-addons
that referenced
this pull request
Jun 11, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: hofingerandi <andreas.hofinger@gmx.net>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Aug 3, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de