[js-transform] Introduced support for additional parameters #10901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
paulianttila
added
rebuild
paulianttila
added
rebuild
fwolter
requested changes
Jul 17, 2021
| if (filename.contains("?")) { | ||
| String[] parts = filename.split("\\?"); | ||
| if (parts.length > 2) { | ||
| throw new TransformationException("Questionmark should be defined only ones in the filename"); |
There was a problem hiding this comment.
Suggested change
| throw new TransformationException("Questionmark should be defined only ones in the filename"); | |
| throw new TransformationException("Questionmark should be defined only once in the filename"); |
bundles/org.openhab.transform.javascript/conf/transform/js/readme/readme.js
Show resolved
Hide resolved
paulianttila
added
the
enhancement
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
fwolter
approved these changes
Jul 31, 2021
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
…10901) * [js-transform] Introduced support for additional parameters Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Added junit tests and updated readme Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Typo fixes Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Typo fix Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Fixed junit test Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…10901) * [js-transform] Introduced support for additional parameters Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Added junit tests and updated readme Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Typo fixes Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Typo fix Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Fixed junit test Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
…10901) * [js-transform] Introduced support for additional parameters Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Added junit tests and updated readme Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Typo fixes Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Typo fix Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Fixed junit test Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…10901) * [js-transform] Introduced support for additional parameters Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Added junit tests and updated readme Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Typo fixes Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Typo fix Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> * Fixed junit test Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5128
Signed-off-by: Pauli Anttila pauli.anttila@gmail.com