Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homekit] Add support for group item type to window covering #10936

Merged

Conversation

ckeehan
Copy link
Contributor

@ckeehan ckeehan commented Jul 4, 2021

Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type

Closes #10812

Signed-off-by: Colin Keehan github@colin.xyz

@ckeehan ckeehan requested a review from yfre as a code owner July 4, 2021 18:16
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/homekit-support-for-rollershutter-group-item/123207/2

Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type

Closes openhab#10812

Signed-off-by: Colin Keehan <github@colin.xyz>
@ckeehan ckeehan force-pushed the 10812-homekit-itemtype-enhancements branch from 4fcc24f to 7925e48 Compare July 4, 2021 18:50
Copy link
Contributor

@yfre yfre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing it
looks good for me

@Skinah Skinah added the enhancement An enhancement or new feature for an existing add-on label Jul 13, 2021
@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jul 15, 2021
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit ff617ac into openhab:main Jul 17, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Jul 17, 2021
dw-8 pushed a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type

Closes openhab#10812

Signed-off-by: Colin Keehan <github@colin.xyz>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8 added a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
dw-8 pushed a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type

Closes openhab#10812

Signed-off-by: Colin Keehan <github@colin.xyz>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8 added a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
…0936)"

This reverts commit 66252b4.

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type

Closes openhab#10812

Signed-off-by: Colin Keehan <github@colin.xyz>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type

Closes openhab#10812

Signed-off-by: Colin Keehan <github@colin.xyz>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type

Closes openhab#10812

Signed-off-by: Colin Keehan <github@colin.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[homekit] Add support for WindowCovering metadata on Group Items
5 participants