Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rfxcom] Add ability to properly receive configured command ids, deprecate hard-coded guesses #10940

Merged
merged 1 commit into from
Jul 18, 2021

Commits on Jul 12, 2021

  1. [rfxcom] Add ability to properly receive configured command ids, depr…

    …ecated hard-coded guesses.
    
    Currently, when a message is received the command will be determined only from the hard-coded set of ON/OFF commands, which means if I configure
    a thing and attach it to a switch there is no guarantee that it will respond as expected to receive commands. This PR changes the message factory
    to require either bytes (from the RFXcom device) or all the details required to make a transmissable message, including the confguration of the
    associated Thing. At the moment, this is only used by lighting4 and raw types, but I expect it will be useful for others in the future.
    
    The hard-coded ON/OFF commands in lighting4 are based on experimentation with different devices, and are not at all consistent. This PR deprecates the
    use of those so that in a future release, Lighting4 devices will only work when configured with the correct command ids up front. This will resolve
    inconsistent behaviour where devices that have been discovered may work correctly, work only for ON or OFF but not both, have ON and OFF the wrong
    way around, turn ON one physical device and OFF another, or any combination of those possibilities.
    
    Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
    Jamstah committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    e3de13b View commit details
    Browse the repository at this point in the history