[hydrawise] Migrate to new GraphQL based API #10947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#7261 Signed-off-by: Dan Cunningham <dan@digitaldan.com>
digitaldan
added
the
bug
fwolter
requested changes
Jul 17, 2021
....hydrawise/src/main/java/org/openhab/binding/hydrawise/internal/HydrawiseHandlerFactory.java
Outdated
Show resolved
Hide resolved
....hydrawise/src/main/java/org/openhab/binding/hydrawise/internal/HydrawiseHandlerFactory.java
Outdated
Show resolved
Hide resolved
....hydrawise/src/main/java/org/openhab/binding/hydrawise/internal/HydrawiseHandlerFactory.java
Outdated
Show resolved
Hide resolved
...g/openhab/binding/hydrawise/internal/discovery/HydrawiseCloudControllerDiscoveryService.java
Outdated
Show resolved
Hide resolved
...se/src/main/java/org/openhab/binding/hydrawise/internal/handler/HydrawiseAccountHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/things.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/things.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
Thanks @fwolter as always for taking the time to review this PR! I have addressed all your comments. |
fwolter
requested changes
Jul 31, 2021
...src/main/java/org/openhab/binding/hydrawise/internal/handler/HydrawiseControllerHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
Thanks @fwolter , i have addressed your latest review comments. |
kaikreuzer
added
rebuild
|
Thanks! |
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Addressed PR comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Address PR review comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Addressed PR comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Address PR review comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com>
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Addressed PR comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Address PR review comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Addressed PR comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Address PR review comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7261
This is a major refactoring of the cloud communication logic due to Hydrawise migrating to a new GraphQL based API about a year ago, breaking the existing binding. Users have been manually installing and testing this branch for about a year as i have dragged my feet getting a PR submitted.
Signed-off-by: Dan Cunningham dan@digitaldan.com