[miio] Change deviceID to Xiaomi used string #10951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the deviceId from the current hexadecimal to the string used by Xiaomi. This is needed as we have some devices that have deviceIds that are non-numeric, hence breaking the current logic. Note: separately removing the upnp discovery as this has become irrelevant with cloud discovery and devices supporting the udp regular discovery. Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcelrv
added
the
enhancement
|
note: jenkins builderror seems unrelated to the PR |
fwolter
requested changes
Jul 6, 2021
...inding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoAbstractHandler.java
Outdated
Show resolved
Hide resolved
…ding/miio/internal/handler/MiIoAbstractHandler.java Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
fwolter
approved these changes
Jul 6, 2021
|
Thanks! |
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
* [miio] change deviceID to Xiaomi used string Change the deviceId from the current hexadecimal to the string used by Xiaomi. This is needed as we have some devices that have deviceIds that are non-numeric, hence breaking the current logic. Note: separately removing the upnp discovery as this has become irrelevant with cloud discovery and devices supporting the udp regular discovery. Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * Update bundles/org.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoAbstractHandler.java Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
* [miio] change deviceID to Xiaomi used string Change the deviceId from the current hexadecimal to the string used by Xiaomi. This is needed as we have some devices that have deviceIds that are non-numeric, hence breaking the current logic. Note: separately removing the upnp discovery as this has become irrelevant with cloud discovery and devices supporting the udp regular discovery. Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * Update bundles/org.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoAbstractHandler.java Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* [miio] change deviceID to Xiaomi used string Change the deviceId from the current hexadecimal to the string used by Xiaomi. This is needed as we have some devices that have deviceIds that are non-numeric, hence breaking the current logic. Note: separately removing the upnp discovery as this has become irrelevant with cloud discovery and devices supporting the udp regular discovery. Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * Update bundles/org.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoAbstractHandler.java Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
wborn
changed the title
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [miio] change deviceID to Xiaomi used string Change the deviceId from the current hexadecimal to the string used by Xiaomi. This is needed as we have some devices that have deviceIds that are non-numeric, hence breaking the current logic. Note: separately removing the upnp discovery as this has become irrelevant with cloud discovery and devices supporting the udp regular discovery. Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * Update bundles/org.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoAbstractHandler.java Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the deviceId from the current hexadecimal to the string used by
Xiaomi.
This is needed as we have some newer devicestypes coming that have deviceIds that are
non-numeric, hence breaking the current logic.
Note: separately removing the upnp discovery as this has become irrelevant with cloud discovery and devices supporting the udp regular discovery.
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com