[espmilight] Add color channels ability to trigger white LEDs #11047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Skinah
added
the
enhancement
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
…b#11047) * Add white shortcut for sat threshold Signed-off-by: Matthew Skinner <matt@pcmus.com> * Fix compiler warnings. Signed-off-by: Matthew Skinner <matt@pcmus.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…b#11047) * Add white shortcut for sat threshold Signed-off-by: Matthew Skinner <matt@pcmus.com> * Fix compiler warnings. Signed-off-by: Matthew Skinner <matt@pcmus.com>
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
…b#11047) * Add white shortcut for sat threshold Signed-off-by: Matthew Skinner <matt@pcmus.com> * Fix compiler warnings. Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…b#11047) * Add white shortcut for sat threshold Signed-off-by: Matthew Skinner <matt@pcmus.com> * Fix compiler warnings. Signed-off-by: Matthew Skinner <matt@pcmus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before these changes with RGB and dual white globes you could not use the color gradients from a color element to switch back to using white LEDs. This change allows a user threshold to be specified where low SATURATION values will change to using the real white LEDs instead of a pastel colour. This is a big improvement as the openHAB colour indicator would show white when the globe was not white.
PR also contains minor refactoring to fix some compiler warnings.
Signed-off-by: Matthew Skinner matt@pcmus.com