Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mielecloud] Remove e-mail parameter validation #11073

Merged

Conversation

BjoernLange
Copy link
Contributor

@BjoernLange BjoernLange commented Jul 31, 2021

Fixes #11050.

Signed-off-by: Björn Lange bjoern.lange@tu-dortmund.de

Signed-off-by: Björn Lange <bjoern.lange@tu-dortmund.de>
@BjoernLange BjoernLange requested a review from a team as a code owner July 31, 2021 20:01
@Skinah Skinah added the bug An unexpected problem or unintended behavior of an add-on label Aug 1, 2021
@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 1, 2021
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 1, 2021
@kaikreuzer
Copy link
Member

@BjoernLange The PR build failed due to an error in the integration tests. Do they succeed locally for you?

@BjoernLange
Copy link
Contributor Author

@kaikreuzer Yes, they do succeed locally. All failing tests concern the configuration UI and assume that it is available under http://127.0.0.1:8080/mielecloud.

@kaikreuzer
Copy link
Member

I'll restart the PR build and see if it was just a temporary hiccup.

@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 2, 2021
@kaikreuzer
Copy link
Member

Hooray, it's green 🎉

@kaikreuzer kaikreuzer merged commit 699b771 into openhab:main Aug 2, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Aug 2, 2021
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
Signed-off-by: Björn Lange <bjoern.lange@tu-dortmund.de>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Signed-off-by: Björn Lange <bjoern.lange@tu-dortmund.de>
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
Signed-off-by: Björn Lange <bjoern.lange@tu-dortmund.de>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Björn Lange <bjoern.lange@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mielecloud] E-Mail check is not RFC compliant
3 participants