Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bluetooth.bluegiga] Fix CompareObjectsWithEquals findings regression causing all devices to be beacons #11179

Merged
merged 1 commit into from
Aug 31, 2021
Merged

[bluetooth.bluegiga] Fix CompareObjectsWithEquals findings regression causing all devices to be beacons #11179

merged 1 commit into from
Aug 31, 2021

Conversation

jmelhus
Copy link
Contributor

@jmelhus jmelhus commented Aug 31, 2021

No description provided.

@jmelhus
I believe commit (f5f922e, 'Fix or suppress SAT CompareObjectsWithEqu…
7684e54 
…als findings') introduced an error when equals was changed to not equals (line 567). Proposing a change where this line is changed back again.

Signed-off-by: Jørgen Melhus <5099412+jmelhus@users.noreply.github.com>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/revival-of-official-bluetooth-binding/92759/182

@jmelhus jmelhus changed the title I believe commit (f5f922e, 'Fix or suppress SAT CompareObjectsWithEquals findings') introduced an error when equals was changed to not equals (line 567). Proposing a change where this line is changed back again. [bluetooth] I believe commit (f5f922e, 'Fix or suppress SAT CompareObjectsWithEquals findings') introduced an error when equals was changed to not equals (line 567). Proposing a change where this line is changed back again. Aug 31, 2021
@jmelhus jmelhus changed the title [bluetooth] I believe commit (f5f922e, 'Fix or suppress SAT CompareObjectsWithEquals findings') introduced an error when equals was changed to not equals (line 567). Proposing a change where this line is changed back again. [bluetooth.bluegiga][bug] I believe commit (f5f922e, 'Fix or suppress SAT CompareObjectsWithEquals findings') introduced an error when equals was changed to not equals (line 567). Proposing a change where this line is changed back again. Aug 31, 2021
@wborn wborn changed the title [bluetooth.bluegiga][bug] I believe commit (f5f922e, 'Fix or suppress SAT CompareObjectsWithEquals findings') introduced an error when equals was changed to not equals (line 567). Proposing a change where this line is changed back again. [bluetooth.bluegiga] Fix CompareObjectsWithEquals findings regression causing all devices to be beacons Aug 31, 2021
wborn
wborn approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for having introduced this regression and thanks for the fix!

@wborn wborn merged commit 2e8fb90 into openhab:main Aug 31, 2021
@wborn wborn added the bug An unexpected problem or unintended behavior of an add-on label Aug 31, 2021
@wborn wborn added this to the 3.2 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@cdjackson cdjackson Awaiting requested review from cdjackson cdjackson is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmelhus @openhab-bot @wborn