Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sagercaster] Enhance binding internals #11295

Merged
merged 9 commits into from
Oct 21, 2021
Merged

[sagercaster] Enhance binding internals #11295

merged 9 commits into from
Oct 21, 2021

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Sep 23, 2021 •
edited
Loading

Added semantic tags
Make it ready for crowndin translation of texts.
Small code improvements.
Used system channels when possible.

Signed-off-by: Gaël L'hopital gael@lhopital.org

@clinique
Added semantic tags
6427d98 
Make it ready for online translation of texts.
Small code improvements

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@lolodomo
Copy link
Contributor

lolodomo commented Oct 3, 2021

I just opened the PR, I think your PR title is clearly not describing its content. The "semantic tag" is 1% of your changes ;)

And I do not understand why you used @text for channel state options, rather than using the usual way ?

@clinique
Copy link
Contributor Author

clinique commented Oct 3, 2021

You're correct, it was my initial intent, but I also found some enhancements to proceed with and switched to the easiest translation mechanism. I did it this way for channel state options as it is easier to translate this way. I'm going to change the PR title.

@clinique clinique changed the title [SagerCaster] Added semantic tags [SagerCaster] binding internals enhancement Oct 3, 2021
@hmerk hmerk added the enhancement An enhancement or new feature for an existing add-on label Oct 4, 2021
@lolodomo
Copy link
Contributor

@clinique : can you please first resolve the conflicting files, I will then have a look.

@clinique
Copy link
Contributor Author

@lolodomo : you should now be ready to go.

@clinique
Code review corrections
d0863a5 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Copy link
Contributor Author

@lolodomo : build fails for errors out of this PR, you can proceed if/when you want.

lolodomo
lolodomo requested changes Oct 17, 2021
View reviewed changes
bundles/org.openhab.binding.sagercaster/src/main/resources/OH-INF/i18n/sagercaster.properties Show resolved Hide resolved
bundles/org.openhab.binding.sagercaster/src/main/resources/OH-INF/i18n/sagercaster.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.sagercaster/src/main/resources/OH-INF/i18n/sagercaster.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.sagercaster/src/main/resources/OH-INF/i18n/sagercaster.properties Outdated Show resolved Hide resolved
...les/org.openhab.binding.sagercaster/src/main/resources/OH-INF/i18n/sagercaster_fr.properties Outdated Show resolved Hide resolved
...les/org.openhab.binding.sagercaster/src/main/resources/OH-INF/i18n/sagercaster_fr.properties Outdated Show resolved Hide resolved
...les/org.openhab.binding.sagercaster/src/main/resources/OH-INF/i18n/sagercaster_fr.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.sagercaster/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.sagercaster/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@clinique
Corrections following lolodomo feed-backs.
c1556a9 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Still some corrections
20b8f39 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Enhanced discovery
c803a69 
Signed-off-by: clinique <gael@lhopital.org>
lolodomo
lolodomo approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

lolodomo commented Oct 18, 2021 •
edited
Loading

Do not enjoy too fast, the build will certainly fail ;)

@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 19, 2021
@lolodomo
Copy link
Contributor

Build finally succeeded

@lolodomo lolodomo merged commit 48fd525 into openhab:main Oct 21, 2021
@lolodomo lolodomo added this to the 3.2 milestone Oct 21, 2021
@clinique clinique deleted the SagerCaster_Tags branch October 22, 2021 09:45
@lolodomo lolodomo changed the title [SagerCaster] binding internals enhancement [sagercaster] binding internals enhancement Oct 22, 2021
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
@clinique @dschoepel
[SagerCaster] binding internals enhancement (openhab#11295)
a4b35a1 
* Added semantic tags
Make it ready for online translation of texts.
Small code improvements

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Update sagercaster_fr.properties

* Correcting encoding for DE resource file.

Signed-off-by: clinique <gael@lhopital.org>

* Code review corrections

Signed-off-by: clinique <gael@lhopital.org>

* Still some code refinings

* Corrections following lolodomo feed-backs.

Signed-off-by: clinique <gael@lhopital.org>

* Still some corrections

Signed-off-by: clinique <gael@lhopital.org>

* Enhanced discovery

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
@wborn wborn changed the title [sagercaster] binding internals enhancement [sagercaster] Enhance binding internals Dec 18, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
@clinique @NickWaterton
[SagerCaster] binding internals enhancement (openhab#11295)
3830230 
* Added semantic tags
Make it ready for online translation of texts.
Small code improvements

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Update sagercaster_fr.properties

* Correcting encoding for DE resource file.

Signed-off-by: clinique <gael@lhopital.org>

* Code review corrections

Signed-off-by: clinique <gael@lhopital.org>

* Still some code refinings

* Corrections following lolodomo feed-backs.

Signed-off-by: clinique <gael@lhopital.org>

* Still some corrections

Signed-off-by: clinique <gael@lhopital.org>

* Enhanced discovery

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@clinique
[SagerCaster] binding internals enhancement (openhab#11295)
94eb9a4 
* Added semantic tags
Make it ready for online translation of texts.
Small code improvements

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Update sagercaster_fr.properties

* Correcting encoding for DE resource file.

Signed-off-by: clinique <gael@lhopital.org>

* Code review corrections

Signed-off-by: clinique <gael@lhopital.org>

* Still some code refinings

* Corrections following lolodomo feed-backs.

Signed-off-by: clinique <gael@lhopital.org>

* Still some corrections

Signed-off-by: clinique <gael@lhopital.org>

* Enhanced discovery

Signed-off-by: clinique <gael@lhopital.org>
volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
@clinique @volkmarnissen
[SagerCaster] binding internals enhancement (openhab#11295)
214de8a 
* Added semantic tags
Make it ready for online translation of texts.
Small code improvements

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Update sagercaster_fr.properties

* Correcting encoding for DE resource file.

Signed-off-by: clinique <gael@lhopital.org>

* Code review corrections

Signed-off-by: clinique <gael@lhopital.org>

* Still some code refinings

* Corrections following lolodomo feed-backs.

Signed-off-by: clinique <gael@lhopital.org>

* Still some corrections

Signed-off-by: clinique <gael@lhopital.org>

* Enhanced discovery

Signed-off-by: clinique <gael@lhopital.org>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@clinique
[SagerCaster] binding internals enhancement (openhab#11295)
db8e062 
* Added semantic tags
Make it ready for online translation of texts.
Small code improvements

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Update sagercaster_fr.properties

* Correcting encoding for DE resource file.

Signed-off-by: clinique <gael@lhopital.org>

* Code review corrections

Signed-off-by: clinique <gael@lhopital.org>

* Still some code refinings

* Corrections following lolodomo feed-backs.

Signed-off-by: clinique <gael@lhopital.org>

* Still some corrections

Signed-off-by: clinique <gael@lhopital.org>

* Enhanced discovery

Signed-off-by: clinique <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn left review comments

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on (potentially) not backward compatible translation
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clinique @lolodomo @wborn @hmerk