[mqtt.homeassistant] Discovery exceptions processing #11315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents discovery Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com>
wborn
added
rebuild
fwolter
approved these changes
Oct 24, 2021
There was a problem hiding this comment.
LGTM
You are quite active on the mqtt.homeassistant binding. If you want to, you could add yourself as the codeowner in the CODEOWNERS file.
@davidgraeff doesn't seem to be active anymore.
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
…omponents discovery (openhab#11315) Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/broken-homeassistant-mqtt-discovery/125102/15 |
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…omponents discovery (openhab#11315) Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…omponents discovery (openhab#11315) Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com>
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
…omponents discovery (openhab#11315) Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…omponents discovery (openhab#11315) Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[mqtt.homeassistant] Discovery exceptions processing
Noticed that exceptions in mqtt message handlers are not processed properly during discovery and even not added to logs.
Mqtt transport implementation doesn't have an information about how to process exceptions, and not handling them.
org.openhab.core.io.transport.mqtt.MqttMessageSubscriber#processMessage
Added exceptions types for component config errors and added exceptions processing to mqtt handlers.
I think the bug could be closed after PR: #11085
Can be reproduced by sending invalid JSON to homeassistant discovery */config topic, for example:
mosquitto_pub -h 127.0.0.1 -p 1883 -t homeassistant/sensor/R5EE70BB9_N321346B4/config -m '{"~":"Bedroom/BME280","dev_cla":"temperature","name":"Bedroom Temperature","stat_t":"~state","unit_of_meas":"°C","json_attributes_topic":"~state","val_tpl":"{{ value_json.temperature }}","uniq_id":"R5EE70BB9_N321346B4","avty_t":"~status","pl_avail":"Online","pl_not_avail":"Offline","device":{"identifiers":["R5EE70BB9"],"connections":["mac","00155D009500"],"name":"BME280 Bedroom"}}'Before PR there are no messages in the log.
After PR:
15:03:24.623 [WARN ] [rnal.discovery.HomeAssistantDiscovery] - HomeAssistant discover error: Cannot parse JSON array. Each connection must be defined as array with two elements: connection_type, connection identifier. For example: "connections": [["mac", "02:5b:26:a8:dc:12"]]