-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[avmfritz] Added support for DECT500 and HAN-FUN bulbs #11348
Merged
lolodomo
merged 2 commits into
openhab:main
from
cweitkamp:feature-7135-avmfritz-dect500
Oct 16, 2021
Merged
[avmfritz] Added support for DECT500 and HAN-FUN bulbs #11348
lolodomo
merged 2 commits into
openhab:main
from
cweitkamp:feature-7135-avmfritz-dect500
Oct 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
lolodomo
requested changes
Oct 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment to fix
...ding.avmfritz/src/main/java/org/openhab/binding/avmfritz/internal/dto/AVMFritzBaseModel.java
Outdated
Show resolved
Hide resolved
lolodomo
requested changes
Oct 9, 2021
...main/java/org/openhab/binding/avmfritz/internal/handler/AVMFritzColorLightDeviceHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
lolodomo
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build failed due to timeout. |
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
* Added support for DECT500 and HAN-FUN bulbs Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated comment from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* Added support for DECT500 and HAN-FUN bulbs Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated comment from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* Added support for DECT500 and HAN-FUN bulbs Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated comment from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
* Added support for DECT500 and HAN-FUN bulbs Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated comment from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Added support for DECT500 and HAN-FUN bulbs Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated comment from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #9757
Closes #7135
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de