-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[upb] Handle device state reports #11352
Conversation
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh3-serialupb-homekit-a-reboot-now-noresponse/126964/13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@marcusb : should we first wait for a community feedback ? |
@lolodomo Let's wait for feedback. |
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@marcusb / what's the status ? Is it ready for merging ? If not, please add the tag "work in progress". |
@lolodomo Still waiting for an update from the tester. I do not have permissions to set labels, and I don't know what's up with the CI status. |
@lolodomo User confirmed it works, please merge. |
* [upb] Fix javadoc Signed-off-by: Marcus Better <marcus@better.se> * [upb] Handle Device State Report messages Signed-off-by: Marcus Better <marcus@better.se> * More useful debug logging of received messages Signed-off-by: Marcus Better <marcus@better.se> * Null annotation Signed-off-by: Marcus Better <marcus@better.se> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
* [upb] Fix javadoc Signed-off-by: Marcus Better <marcus@better.se> * [upb] Handle Device State Report messages Signed-off-by: Marcus Better <marcus@better.se> * More useful debug logging of received messages Signed-off-by: Marcus Better <marcus@better.se> * Null annotation Signed-off-by: Marcus Better <marcus@better.se> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
* [upb] Fix javadoc Signed-off-by: Marcus Better <marcus@better.se> * [upb] Handle Device State Report messages Signed-off-by: Marcus Better <marcus@better.se> * More useful debug logging of received messages Signed-off-by: Marcus Better <marcus@better.se> * Null annotation Signed-off-by: Marcus Better <marcus@better.se>
* [upb] Fix javadoc Signed-off-by: Marcus Better <marcus@better.se> * [upb] Handle Device State Report messages Signed-off-by: Marcus Better <marcus@better.se> * More useful debug logging of received messages Signed-off-by: Marcus Better <marcus@better.se> * Null annotation Signed-off-by: Marcus Better <marcus@better.se>
* [upb] Fix javadoc Signed-off-by: Marcus Better <marcus@better.se> * [upb] Handle Device State Report messages Signed-off-by: Marcus Better <marcus@better.se> * More useful debug logging of received messages Signed-off-by: Marcus Better <marcus@better.se> * Null annotation Signed-off-by: Marcus Better <marcus@better.se>
Device state reports are sent out by devices when their state is changed manually,
such as when pressing a light switch. This handles the messages by updating
the thing state in openHAB accordingly.