Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upb] Handle device state reports #11352

Merged
merged 4 commits into from
Oct 21, 2021
Merged

[upb] Handle device state reports #11352

merged 4 commits into from
Oct 21, 2021

Conversation

marcusb
Copy link
Contributor

@marcusb marcusb commented Oct 6, 2021

Device state reports are sent out by devices when their state is changed manually,
such as when pressing a light switch. This handles the messages by updating
the thing state in openHAB accordingly.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh3-serialupb-homekit-a-reboot-now-noresponse/126964/13

@Skinah Skinah added the enhancement An enhancement or new feature for an existing add-on label Oct 7, 2021
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

lolodomo commented Oct 9, 2021

@marcusb : should we first wait for a community feedback ?

@marcusb
Copy link
Contributor Author

marcusb commented Oct 10, 2021

@lolodomo Let's wait for feedback.

Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

@marcusb / what's the status ? Is it ready for merging ? If not, please add the tag "work in progress".
I don't know why the DCO is not green. If you could fix that, that would be perfect.

@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 16, 2021
@marcusb
Copy link
Contributor Author

marcusb commented Oct 17, 2021

@lolodomo Still waiting for an update from the tester.

I do not have permissions to set labels, and I don't know what's up with the CI status.

@lolodomo lolodomo added the work in progress A PR that is not yet ready to be merged label Oct 17, 2021
@marcusb
Copy link
Contributor Author

marcusb commented Oct 20, 2021

@lolodomo User confirmed it works, please merge.

@lolodomo lolodomo removed the work in progress A PR that is not yet ready to be merged label Oct 21, 2021
@lolodomo lolodomo merged commit daea648 into openhab:main Oct 21, 2021
@lolodomo lolodomo added this to the 3.2 milestone Oct 21, 2021
@marcusb marcusb deleted the device-state branch October 22, 2021 01:01
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
* [upb] Fix javadoc

Signed-off-by: Marcus Better <marcus@better.se>

* [upb] Handle Device State Report messages

Signed-off-by: Marcus Better <marcus@better.se>

* More useful debug logging of received messages

Signed-off-by: Marcus Better <marcus@better.se>

* Null annotation

Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
* [upb] Fix javadoc

Signed-off-by: Marcus Better <marcus@better.se>

* [upb] Handle Device State Report messages

Signed-off-by: Marcus Better <marcus@better.se>

* More useful debug logging of received messages

Signed-off-by: Marcus Better <marcus@better.se>

* Null annotation

Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
* [upb] Fix javadoc

Signed-off-by: Marcus Better <marcus@better.se>

* [upb] Handle Device State Report messages

Signed-off-by: Marcus Better <marcus@better.se>

* More useful debug logging of received messages

Signed-off-by: Marcus Better <marcus@better.se>

* Null annotation

Signed-off-by: Marcus Better <marcus@better.se>
volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
* [upb] Fix javadoc

Signed-off-by: Marcus Better <marcus@better.se>

* [upb] Handle Device State Report messages

Signed-off-by: Marcus Better <marcus@better.se>

* More useful debug logging of received messages

Signed-off-by: Marcus Better <marcus@better.se>

* Null annotation

Signed-off-by: Marcus Better <marcus@better.se>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* [upb] Fix javadoc

Signed-off-by: Marcus Better <marcus@better.se>

* [upb] Handle Device State Report messages

Signed-off-by: Marcus Better <marcus@better.se>

* More useful debug logging of received messages

Signed-off-by: Marcus Better <marcus@better.se>

* Null annotation

Signed-off-by: Marcus Better <marcus@better.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants