[wemo] Fix wrong brightness value for dimmer switch #11385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/wemo-dimmer-brightness-display-wrong-value/126838/8 |
Hilbrand
reviewed
Oct 14, 2021
....binding.wemo/src/main/java/org/openhab/binding/wemo/internal/handler/WemoDimmerHandler.java
Outdated
Show resolved
Hide resolved
…ding/wemo/internal/handler/WemoDimmerHandler.java Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
lolodomo
requested changes
Oct 15, 2021
....binding.wemo/src/main/java/org/openhab/binding/wemo/internal/handler/WemoDimmerHandler.java
Outdated
Show resolved
Hide resolved
hmerk
added
rebuild
|
@hmerk : pleaser do not set the milestone/ It has to be set when the PR is merged. |
|
@lolodomo Ok, will respect this for the future. |
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
* [wemo] fix wrong brightness value for dimmer switch Signed-off-by: Hans-Jörg Merk <github@hmerk.de> * Update bundles/org.openhab.binding.wemo/src/main/java/org/openhab/binding/wemo/internal/handler/WemoDimmerHandler.java Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * Remove @nullable on simple variable Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
* [wemo] fix wrong brightness value for dimmer switch Signed-off-by: Hans-Jörg Merk <github@hmerk.de> * Update bundles/org.openhab.binding.wemo/src/main/java/org/openhab/binding/wemo/internal/handler/WemoDimmerHandler.java Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * Remove @nullable on simple variable Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
wborn
changed the title
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* [wemo] fix wrong brightness value for dimmer switch Signed-off-by: Hans-Jörg Merk <github@hmerk.de> * Update bundles/org.openhab.binding.wemo/src/main/java/org/openhab/binding/wemo/internal/handler/WemoDimmerHandler.java Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * Remove @nullable on simple variable Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* [wemo] fix wrong brightness value for dimmer switch Signed-off-by: Hans-Jörg Merk <github@hmerk.de> * Update bundles/org.openhab.binding.wemo/src/main/java/org/openhab/binding/wemo/internal/handler/WemoDimmerHandler.java Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * Remove @nullable on simple variable Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
* [wemo] fix wrong brightness value for dimmer switch Signed-off-by: Hans-Jörg Merk <github@hmerk.de> * Update bundles/org.openhab.binding.wemo/src/main/java/org/openhab/binding/wemo/internal/handler/WemoDimmerHandler.java Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * Remove @nullable on simple variable Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [wemo] fix wrong brightness value for dimmer switch Signed-off-by: Hans-Jörg Merk <github@hmerk.de> * Update bundles/org.openhab.binding.wemo/src/main/java/org/openhab/binding/wemo/internal/handler/WemoDimmerHandler.java Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl> * Remove @nullable on simple variable Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hans-Jörg Merk github@hmerk.de