Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ipcamera] Improvements and fix 503 errors go to offline with Hik #11419

Merged
merged 16 commits into from
Oct 24, 2021
Merged

[ipcamera] Improvements and fix 503 errors go to offline with Hik #11419

merged 16 commits into from
Oct 24, 2021

Conversation

Skinah
Copy link
Contributor

@Skinah Skinah commented Oct 20, 2021 •
edited
Loading

Multiple bug fixes and improvements:

  • Fix for Hikvision cameras going offline when cameras report 503 busy errors.
  • Cleaner logs for Dahua events.
  • Cleaner logs for Hikvision to stop 401 messages in trace which are normal for digest auths.
  • Fix buffer overflow from occurring for ipcamera.mjpeg streams.
  • Generic cameras now will restart the RTSP to jpg creation automatically if camera or network closes the stream.
  • Use smaller threadpools to lower impact on resources.
  • pollTime config moved to advanced to clean up the setup of cameras.
  • Lower network traffic for cameras that can use non stop event streams to determine if camera is online or not.

Precompiled jar can be downloaded here
http://pcmus.com/openhab/IpCameraBinding/
NOTE: Install the tellstick binding for the Netty dependancies or install them via console.

Signed-off-by: Matthew Skinner matt@pcmus.com

@Skinah
Stop hik logging 401 with digest.
5e60731 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Improve and fix generic cams
16a6e1e 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Stop dahua IntelliFrame logging
62b8289 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Catch IllegalStateException
7bd9b88 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Trial reusing channels.
8ef6634 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Tidy up
58bb19b 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
cleanup 2
e98ddfb 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Cleanup 3
cc17329 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Disable checking connection with event stream.
aad1866 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Bug fix
23c9b17 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
more cleanup
ff7a591 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah Skinah added the bug An unexpected problem or unintended behavior of an add-on label Oct 20, 2021
@Skinah
more cleanup
13f713d 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 20, 2021
@Skinah Skinah changed the title [ipcamera] Multiple bug fixes to solve 503 errors going offline [ipcamera] Improvements and fix 503 errors go to offline with Hik Oct 20, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/ipcamera-binding-breaking-changes-and-new-features-in-3-2-milestone-3-and-newer/126735/19

@Skinah Skinah added the enhancement An enhancement or new feature for an existing add-on label Oct 20, 2021
@Skinah
Reduce logging to only whats needed.
cf97119 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
fix offline detection.
620aed7 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
fixes to ipcamera.mjpeg
49a8ec3 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
reverse some connection checks
8cebd70 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@fwolter fwolter merged commit 04ba8d3 into openhab:main Oct 24, 2021
@fwolter fwolter added this to the 3.2 milestone Oct 24, 2021
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
@Skinah @dschoepel
[ipcamera] Improvements and fix 503 errors go to offline with Hik (op…
894ae20 
…enhab#11419)

* Stop hik logging 401 with digest.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Improve and fix generic cams

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Stop dahua IntelliFrame logging

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Catch IllegalStateException

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Trial reusing channels.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Tidy up

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* cleanup 2

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Cleanup 3

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Disable checking connection with event stream.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Bug fix

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* more cleanup

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* more cleanup

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Reduce logging to only whats needed.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* fix offline detection.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* fixes to ipcamera.mjpeg

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* reverse some connection checks

Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
@Skinah @NickWaterton
[ipcamera] Improvements and fix 503 errors go to offline with Hik (op…
a51b776 
…enhab#11419)

* Stop hik logging 401 with digest.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Improve and fix generic cams


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Stop dahua IntelliFrame logging


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Catch IllegalStateException


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Trial reusing channels.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Tidy up


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* cleanup 2


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Cleanup 3


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Disable checking connection with event stream.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Bug fix


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* more cleanup


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* more cleanup

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Reduce logging to only whats needed.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* fix offline detection.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* fixes to ipcamera.mjpeg


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* reverse some connection checks


Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@Skinah
[ipcamera] Improvements and fix 503 errors go to offline with Hik (op…
38143e7 
…enhab#11419)

* Stop hik logging 401 with digest.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Improve and fix generic cams


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Stop dahua IntelliFrame logging


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Catch IllegalStateException


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Trial reusing channels.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Tidy up


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* cleanup 2


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Cleanup 3


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Disable checking connection with event stream.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Bug fix


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* more cleanup


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* more cleanup

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Reduce logging to only whats needed.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* fix offline detection.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* fixes to ipcamera.mjpeg


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* reverse some connection checks


Signed-off-by: Matthew Skinner <matt@pcmus.com>
volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
@Skinah @volkmarnissen
[ipcamera] Improvements and fix 503 errors go to offline with Hik (op…
8670bbb 
…enhab#11419)

* Stop hik logging 401 with digest.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Improve and fix generic cams


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Stop dahua IntelliFrame logging


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Catch IllegalStateException


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Trial reusing channels.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Tidy up


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* cleanup 2


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Cleanup 3


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Disable checking connection with event stream.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Bug fix


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* more cleanup


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* more cleanup

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Reduce logging to only whats needed.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* fix offline detection.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* fixes to ipcamera.mjpeg


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* reverse some connection checks


Signed-off-by: Matthew Skinner <matt@pcmus.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@Skinah
[ipcamera] Improvements and fix 503 errors go to offline with Hik (op…
359ea8f 
…enhab#11419)

* Stop hik logging 401 with digest.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Improve and fix generic cams


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Stop dahua IntelliFrame logging


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Catch IllegalStateException


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Trial reusing channels.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Tidy up


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* cleanup 2


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Cleanup 3


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Disable checking connection with event stream.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Bug fix


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* more cleanup


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* more cleanup

Signed-off-by: Matthew Skinner <matt@pcmus.com>

* Reduce logging to only whats needed.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* fix offline detection.


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* fixes to ipcamera.mjpeg


Signed-off-by: Matthew Skinner <matt@pcmus.com>

* reverse some connection checks


Signed-off-by: Matthew Skinner <matt@pcmus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Skinah @openhab-bot @fwolter @kaikreuzer