Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miele] Clean up properties and improve reliability and performance #11423

Merged
merged 26 commits into from
Nov 1, 2021
Merged

[miele] Clean up properties and improve reliability and performance #11423

merged 26 commits into from
Nov 1, 2021

Commits on Oct 23, 2021

  1. Use appliance cache for getting full UID with protocol prefix instead… 

    … of relying on property.

Fixes openhab#11422

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    0d7223c View commit details
    Browse the repository at this point in the history

  2. Set bare protocol name as property. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    4768ebf View commit details
    Browse the repository at this point in the history

  3. Fix potential null pointer access warnings. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    5194e98 View commit details
    Browse the repository at this point in the history

  4. Remove unused import. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    b0d85ce View commit details
    Browse the repository at this point in the history

  5. Renamed property protocol to protocolAdapter for correctness. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    f0cd04a View commit details
    Browse the repository at this point in the history

  6. Add connectionType property. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    dcebb25 View commit details
    Browse the repository at this point in the history

  7. Add appliance model property. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    b6498c5 View commit details
    Browse the repository at this point in the history

  8. Remove useless properties brandId and companyId always having value MI. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    c6b4589 View commit details
    Browse the repository at this point in the history

  9. Rename property dc to deviceClass and set it consistently (not only f… 

    …rom auto-discovered things).

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    043e712 View commit details
    Browse the repository at this point in the history

  10. Added constants for remaining handlers with hardcoded device classes. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    743c7d2 View commit details
    Browse the repository at this point in the history

  11. Fix SCA: AuthorContributionDescriptionCheck 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    8a36af1 View commit details
    Browse the repository at this point in the history

  12. Fix SCA: ModifierOrderCheck 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    c8eda22 View commit details
    Browse the repository at this point in the history

  13. Rename ExtendedDeviceStateUtil to be a bit more generic. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    52f40a9 View commit details
    Browse the repository at this point in the history

  14. Extract device class string parsing to utility method. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    8e3767d View commit details
    Browse the repository at this point in the history

  15. Fix SCA: ForbiddenPackageUsageCheck 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    f78438e View commit details
    Browse the repository at this point in the history

  16. Fix redundant null check. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    4aba034 View commit details
    Browse the repository at this point in the history

  17. Fix potential null pointer access warnings. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    529a5c7 View commit details
    Browse the repository at this point in the history

  18. Fix unsafe null type conversion (type annotations) 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    32d4167 View commit details
    Browse the repository at this point in the history

  19. Share same configuration (UID) for all appliance types. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    9af1bbc View commit details
    Browse the repository at this point in the history

  20. Refer to gateway instead of ZigBee network in configuration. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    bde2296 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2021

  1. Remove dependency to seriaNumber property for multicast channel updates. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    55e0955 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Simplified filtering of irrelevant device class. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    8317f1f View commit details
    Browse the repository at this point in the history

  2. Remove devices from remoteUid cache also when disappearing from gatew… 

    …ay, although this is a quite rare scenario.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    81cd541 View commit details
    Browse the repository at this point in the history

  3. Fix potential null pointer access. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    b2b166d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2021

  1. Add default i18n properties file. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    bd05546 View commit details
    Browse the repository at this point in the history

  2. Add partial Danish translation. 

    Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
    @jlaur
    jlaur committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    d24a9ba View commit details
    Browse the repository at this point in the history