Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homematic] Improve (re)connect handling to Homematic gateways #11429

Merged
merged 12 commits into from
Dec 11, 2021
Merged

[homematic] Improve (re)connect handling to Homematic gateways #11429

merged 12 commits into from
Dec 11, 2021

Commits on Dec 11, 2021

  1. Use globally unique id for registration of callback to allow ... 

    the connection of multiple OH installations with one CCU.

The bridge id is not sufficient for this purpose because it is same in
all OH installations.


Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    f3765b1 View commit details
    Browse the repository at this point in the history

  2. Retry callback re-registration after connection is resumed 

    Some services on the CCU need longer to start and are not available
immediately after the connection to the CCU has been resumed.

Improves the solution for #8808

Fixes #10439

Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    f147aa9 View commit details
    Browse the repository at this point in the history

  3. Description was missing. 

    Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    f28ba2f View commit details
    Browse the repository at this point in the history

  4. Changed setting name and description to avoid confusion 

    Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    d5f46c2 View commit details
    Browse the repository at this point in the history

  5. Added a troubleshooting tip to solve a communication problem 

    Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    9faec99 View commit details
    Browse the repository at this point in the history

  6. Shortened the label name to follow the guide lines 

    Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    3c9150b View commit details
    Browse the repository at this point in the history

  7. Print more information about the reason for the failure 

    Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    30f3d0e View commit details
    Browse the repository at this point in the history

  8. Using scheduler thread pool and simplified configuration 

    Instead of configuring separate values for retry delays and number of
retries only the maximum time for retries can be configured.
The init method uses fixed delays.

Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    98a2d76 View commit details
    Browse the repository at this point in the history

  9. Don't retry to send if gateway does not answer at all 

    Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    68bd4a0 View commit details
    Browse the repository at this point in the history

  10. Improved reconnect handling 

    - unregister callback not necessary if connection is lost
- wait 30s until clients and servers are restarted to give the gateway
some time to recover

Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    671231a View commit details
    Browse the repository at this point in the history

  11. Spotless 

    Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    4d63703 View commit details
    Browse the repository at this point in the history

  12. Cancel an active future if the binding is stopped 

    Signed-off-by: Martin Herbst <develop@mherbst.de>
    @MHerbst
    MHerbst committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    0a9fe99 View commit details
    Browse the repository at this point in the history