-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[souliss] Fix discovery issue #11438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
onOff to CamelCase Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
fixed label cases Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
This reverts commit 5c19fbc. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Default case on switch (handlecommand ) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Cutted comments and uneccessary log on gw status Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
fixed some npe Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Remove comments unused code Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
spotless:apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
call super on initialize() of all handlers. Changed to QuantityType where appliable Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
added uniqueId (ip of gateway+node+slot) as representationProperty Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
wrong format .. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
fwolter
reviewed
Oct 24, 2021
...ss/src/main/java/org/openhab/binding/souliss/internal/discovery/SoulissGatewayDiscovery.java
Outdated
Show resolved
Hide resolved
Comment removed Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lolodomo
requested changes
Oct 24, 2021
...ss/src/main/java/org/openhab/binding/souliss/internal/discovery/SoulissGatewayDiscovery.java
Outdated
Show resolved
Hide resolved
...ss/src/main/java/org/openhab/binding/souliss/internal/discovery/SoulissGatewayDiscovery.java
Outdated
Show resolved
Hide resolved
cleanup ... Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
reintroduced local var for avoid SAT warning Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lolodomo
requested changes
Oct 25, 2021
...ss/src/main/java/org/openhab/binding/souliss/internal/discovery/SoulissGatewayDiscovery.java
Show resolved
Hide resolved
fix error ...nuances Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
fwolter
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't set the milestone as the binding wasn't released with a milestone, yet. |
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
* Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Renamed healty in healthy (simple word error) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml onOff to CamelCase Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * camelCase fixed on some types Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed camelCase on thhings parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml fixed label cases Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Revert "Update thing-types.xml" This reverts commit 5c19fbc. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fix some errors (Nullable issues) and pom.xml format Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java Default case on switch (handlecommand ) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * added secoresend to t31 skeleton and variable smessage fix declaration Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java Cutted comments and uneccessary log on gw status Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Renamed healty in healthy (simple word error) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed camelCase on thhings parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup and quality code fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingUDPDecoder.java fixed some npe Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * npe check fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java Remove comments unused code Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java commented out code unused Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java remove unused code commented out Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingUDPServerJob.java remove unused code comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingSendDispatcherJob.java fixed logger trace and remove unused code comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed completely unnecessary comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed some thing types cases Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java removed unnecessary log line Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java removed unnecessary comment Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * loggers as final ! Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayJobHealthy.java removed unnecessary logs Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayJobPing.java removed unnecessary logs Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed redundancy on types checks Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md fixed examples parms Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java changed parm var name bridge Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT11Handler.java remove comments Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT12Handler.java comments removed Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT13Handler.java comments removed Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed thing type on README and some case on xml thing types Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md cutted part about manually thing config specs on README . Who use oh already knows it . Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Code cleanup and optimizations based on @Skinah tips Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes from @Skinah suggestions Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Fixed typeid's on costants files Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various optimizations follow @Skinah tips (thanks!) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes constants and channel id types of t31 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fix various NPE warnings Fixes many ... Some added suppresswarnings. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericActionMessage.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Refactor handlers into souliss.internal.handler Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spoless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix t19 (securesend parm ,labels and setvalue) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Null checks Warnings removed (mitigated with local copy of field) - removed comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * syntax sugar fixed of consts and section removed from README Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * moved files to internal package Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissHandlerFactory.java check types on object and not on strings Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Gateway ip address regex on config param Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * changed description of gateway ip on param Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * formatted tables in README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip for npe checks - breaking functionality :-( Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless fix Author: Luca Calcaterra <calcaterra.luca@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix contrib header in some files Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * reworked udp - only one bridge allowed and UDP listen only to bridge port 230 ...passing datagramsocket with soulissnetworkparameter class Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * quite ok. Where to close socket in case of thread interruption ? Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip2 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip3 udp receive but not on vpn Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Classes names Refactor Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * replaced datagramsocket with nio socket- seems to be ok Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fixed some null checks removed securesend option (only t11 end similar) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * dummy initial value of raw values - removed thread on decoder line Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix t19 ex catch and broadcast function Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Reworked Config of Gateway as Class (todo check nulls...) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Added representation property on gw - some cleanups Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java cleanup unused vars Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * refactor methods of gw parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP to remove NetworkParameter class Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip refactor DiscoverResult Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip remove networkparameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP remove NetworkParameter Class. Things online only on a health message Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP Fix Topics Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP2 Fix topics Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml upgrade binding version to 3.2 snapshot Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * topics bound to bridge - seems to be ok. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * remove NetworkParameters class - topics ok but need parse rework Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * code cleanup and bugs check fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Add node and slot to property - other fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * change default interval subscription -cleanup constants Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP WAN Address gw Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WAN option external network. Fixed Putin on commands - to test well Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup - safesend check WIP Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed secursend for t11-18 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP Fix null checks Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericHandler.java fixed wrong assignment of prop Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * null checks fixes for code quality Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed listen port according to gw parm (default 23000) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * nuances Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml changed default values Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * CommonCommands to static - other fixes . seems quite ok, remain T31 to fix (securesend) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java changed executor imp for udp Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * restored commoncommands non static Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SendDispatcherRunnable.java safesendcheck fix (not really) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various nuances (sonarlint) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md removed explain how oh works on example Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/feature/feature.xml Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * @fwolter various fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java wrong header Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix headers descriptions before authors on all classes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * all var on begin of classes and @nullable sugar syntax Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed @nullable on local vars Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip comments translations and cleanup Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup comments and translated them (if italian occourred) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * @fwolter suggestions for approval...various fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter suggestions. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter suggestions. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java hexutils usage Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT22Handler.java removed unused method Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT22Handler.java fix previous commit Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java @nullable on configuration Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * method to put bridge offline (network exception on listener) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml changed some channels to trigger type Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP broken Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml spotless:apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various changes call super on initialize() of all handlers. Changed to QuantityType where appliable Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java added uniqueId (ip of gateway+node+slot) as representationProperty Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip for load discovery component Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * big fixes and code quality improvments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericHandler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md wrong format .. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix null soulissGwHandler and code analysis Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java Comment removed Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java cleanup ... Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java reintroduced local var for avoid SAT warning Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java fix error ...nuances Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-authored-by: Tonino Fazio <fazioa@gmail.com> Co-authored-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Renamed healty in healthy (simple word error) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml onOff to CamelCase Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * camelCase fixed on some types Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed camelCase on thhings parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml fixed label cases Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Revert "Update thing-types.xml" This reverts commit 5c19fbc. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fix some errors (Nullable issues) and pom.xml format Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java Default case on switch (handlecommand ) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * added secoresend to t31 skeleton and variable smessage fix declaration Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java Cutted comments and uneccessary log on gw status Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Renamed healty in healthy (simple word error) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed camelCase on thhings parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup and quality code fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingUDPDecoder.java fixed some npe Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * npe check fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java Remove comments unused code Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java commented out code unused Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java remove unused code commented out Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingUDPServerJob.java remove unused code comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingSendDispatcherJob.java fixed logger trace and remove unused code comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed completely unnecessary comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed some thing types cases Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java removed unnecessary log line Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java removed unnecessary comment Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * loggers as final ! Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayJobHealthy.java removed unnecessary logs Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayJobPing.java removed unnecessary logs Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed redundancy on types checks Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md fixed examples parms Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java changed parm var name bridge Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT11Handler.java remove comments Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT12Handler.java comments removed Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT13Handler.java comments removed Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed thing type on README and some case on xml thing types Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md cutted part about manually thing config specs on README . Who use oh already knows it . Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Code cleanup and optimizations based on @Skinah tips Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes from @Skinah suggestions Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Fixed typeid's on costants files Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various optimizations follow @Skinah tips (thanks!) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes constants and channel id types of t31 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fix various NPE warnings Fixes many ... Some added suppresswarnings. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericActionMessage.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Refactor handlers into souliss.internal.handler Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spoless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix t19 (securesend parm ,labels and setvalue) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Null checks Warnings removed (mitigated with local copy of field) - removed comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * syntax sugar fixed of consts and section removed from README Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * moved files to internal package Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissHandlerFactory.java check types on object and not on strings Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Gateway ip address regex on config param Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * changed description of gateway ip on param Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * formatted tables in README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip for npe checks - breaking functionality :-( Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless fix Author: Luca Calcaterra <calcaterra.luca@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix contrib header in some files Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * reworked udp - only one bridge allowed and UDP listen only to bridge port 230 ...passing datagramsocket with soulissnetworkparameter class Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * quite ok. Where to close socket in case of thread interruption ? Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip2 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip3 udp receive but not on vpn Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Classes names Refactor Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * replaced datagramsocket with nio socket- seems to be ok Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fixed some null checks removed securesend option (only t11 end similar) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * dummy initial value of raw values - removed thread on decoder line Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix t19 ex catch and broadcast function Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Reworked Config of Gateway as Class (todo check nulls...) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Added representation property on gw - some cleanups Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java cleanup unused vars Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * refactor methods of gw parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP to remove NetworkParameter class Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip refactor DiscoverResult Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip remove networkparameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP remove NetworkParameter Class. Things online only on a health message Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP Fix Topics Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP2 Fix topics Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml upgrade binding version to 3.2 snapshot Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * topics bound to bridge - seems to be ok. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * remove NetworkParameters class - topics ok but need parse rework Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * code cleanup and bugs check fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Add node and slot to property - other fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * change default interval subscription -cleanup constants Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP WAN Address gw Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WAN option external network. Fixed Putin on commands - to test well Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup - safesend check WIP Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed secursend for t11-18 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP Fix null checks Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericHandler.java fixed wrong assignment of prop Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * null checks fixes for code quality Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed listen port according to gw parm (default 23000) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * nuances Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml changed default values Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * CommonCommands to static - other fixes . seems quite ok, remain T31 to fix (securesend) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java changed executor imp for udp Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * restored commoncommands non static Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SendDispatcherRunnable.java safesendcheck fix (not really) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various nuances (sonarlint) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md removed explain how oh works on example Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/feature/feature.xml Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * @fwolter various fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java wrong header Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix headers descriptions before authors on all classes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * all var on begin of classes and @nullable sugar syntax Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed @nullable on local vars Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip comments translations and cleanup Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup comments and translated them (if italian occourred) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * @fwolter suggestions for approval...various fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter suggestions. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter suggestions. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java hexutils usage Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT22Handler.java removed unused method Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT22Handler.java fix previous commit Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java @nullable on configuration Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * method to put bridge offline (network exception on listener) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml changed some channels to trigger type Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP broken Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml spotless:apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various changes call super on initialize() of all handlers. Changed to QuantityType where appliable Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java added uniqueId (ip of gateway+node+slot) as representationProperty Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip for load discovery component Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * big fixes and code quality improvments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericHandler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md wrong format .. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix null soulissGwHandler and code analysis Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java Comment removed Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java cleanup ... Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java reintroduced local var for avoid SAT warning Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java fix error ...nuances Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-authored-by: Tonino Fazio <fazioa@gmail.com> Co-authored-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Renamed healty in healthy (simple word error) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml onOff to CamelCase Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * camelCase fixed on some types Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed camelCase on thhings parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml fixed label cases Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Revert "Update thing-types.xml" This reverts commit 5c19fbc. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fix some errors (Nullable issues) and pom.xml format Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java Default case on switch (handlecommand ) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * added secoresend to t31 skeleton and variable smessage fix declaration Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java Cutted comments and uneccessary log on gw status Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Renamed healty in healthy (simple word error) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed camelCase on thhings parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup and quality code fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingUDPDecoder.java fixed some npe Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * npe check fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java Remove comments unused code Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java commented out code unused Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java remove unused code commented out Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingUDPServerJob.java remove unused code comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingSendDispatcherJob.java fixed logger trace and remove unused code comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed completely unnecessary comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed some thing types cases Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java removed unnecessary log line Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java removed unnecessary comment Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * loggers as final ! Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayJobHealthy.java removed unnecessary logs Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayJobPing.java removed unnecessary logs Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed redundancy on types checks Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md fixed examples parms Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java changed parm var name bridge Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT11Handler.java remove comments Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT12Handler.java comments removed Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT13Handler.java comments removed Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed thing type on README and some case on xml thing types Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md cutted part about manually thing config specs on README . Who use oh already knows it . Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Code cleanup and optimizations based on @Skinah tips Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes from @Skinah suggestions Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Fixed typeid's on costants files Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various optimizations follow @Skinah tips (thanks!) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes constants and channel id types of t31 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fix various NPE warnings Fixes many ... Some added suppresswarnings. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericActionMessage.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Refactor handlers into souliss.internal.handler Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spoless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix t19 (securesend parm ,labels and setvalue) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Null checks Warnings removed (mitigated with local copy of field) - removed comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * syntax sugar fixed of consts and section removed from README Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * moved files to internal package Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissHandlerFactory.java check types on object and not on strings Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Gateway ip address regex on config param Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * changed description of gateway ip on param Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * formatted tables in README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip for npe checks - breaking functionality :-( Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless fix Author: Luca Calcaterra <calcaterra.luca@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix contrib header in some files Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * reworked udp - only one bridge allowed and UDP listen only to bridge port 230 ...passing datagramsocket with soulissnetworkparameter class Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * quite ok. Where to close socket in case of thread interruption ? Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip2 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip3 udp receive but not on vpn Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Classes names Refactor Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * replaced datagramsocket with nio socket- seems to be ok Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fixed some null checks removed securesend option (only t11 end similar) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * dummy initial value of raw values - removed thread on decoder line Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix t19 ex catch and broadcast function Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Reworked Config of Gateway as Class (todo check nulls...) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Added representation property on gw - some cleanups Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java cleanup unused vars Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * refactor methods of gw parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP to remove NetworkParameter class Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip refactor DiscoverResult Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip remove networkparameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP remove NetworkParameter Class. Things online only on a health message Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP Fix Topics Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP2 Fix topics Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml upgrade binding version to 3.2 snapshot Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * topics bound to bridge - seems to be ok. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * remove NetworkParameters class - topics ok but need parse rework Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * code cleanup and bugs check fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Add node and slot to property - other fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * change default interval subscription -cleanup constants Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP WAN Address gw Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WAN option external network. Fixed Putin on commands - to test well Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup - safesend check WIP Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed secursend for t11-18 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP Fix null checks Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericHandler.java fixed wrong assignment of prop Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * null checks fixes for code quality Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed listen port according to gw parm (default 23000) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * nuances Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml changed default values Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * CommonCommands to static - other fixes . seems quite ok, remain T31 to fix (securesend) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java changed executor imp for udp Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * restored commoncommands non static Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SendDispatcherRunnable.java safesendcheck fix (not really) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various nuances (sonarlint) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md removed explain how oh works on example Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/feature/feature.xml Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * @fwolter various fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java wrong header Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix headers descriptions before authors on all classes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * all var on begin of classes and @nullable sugar syntax Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed @nullable on local vars Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip comments translations and cleanup Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup comments and translated them (if italian occourred) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * @fwolter suggestions for approval...various fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter suggestions. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter suggestions. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java hexutils usage Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT22Handler.java removed unused method Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT22Handler.java fix previous commit Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java @nullable on configuration Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * method to put bridge offline (network exception on listener) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml changed some channels to trigger type Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP broken Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml spotless:apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various changes call super on initialize() of all handlers. Changed to QuantityType where appliable Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java added uniqueId (ip of gateway+node+slot) as representationProperty Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip for load discovery component Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * big fixes and code quality improvments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericHandler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md wrong format .. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix null soulissGwHandler and code analysis Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java Comment removed Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java cleanup ... Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java reintroduced local var for avoid SAT warning Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java fix error ...nuances Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-authored-by: Tonino Fazio <fazioa@gmail.com> Co-authored-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
* Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Renamed healty in healthy (simple word error) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml onOff to CamelCase Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * camelCase fixed on some types Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed camelCase on thhings parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml fixed label cases Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Revert "Update thing-types.xml" This reverts commit 5c19fbc. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fix some errors (Nullable issues) and pom.xml format Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java Default case on switch (handlecommand ) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * added secoresend to t31 skeleton and variable smessage fix declaration Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java Cutted comments and uneccessary log on gw status Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Renamed healty in healthy (simple word error) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed camelCase on thhings parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup and quality code fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingUDPDecoder.java fixed some npe Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * npe check fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java Remove comments unused code Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java commented out code unused Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java remove unused code commented out Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingUDPServerJob.java remove unused code comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingSendDispatcherJob.java fixed logger trace and remove unused code comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed completely unnecessary comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed some thing types cases Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java removed unnecessary log line Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java removed unnecessary comment Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * loggers as final ! Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayJobHealthy.java removed unnecessary logs Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayJobPing.java removed unnecessary logs Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed redundancy on types checks Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md fixed examples parms Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java changed parm var name bridge Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT11Handler.java remove comments Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT12Handler.java comments removed Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT13Handler.java comments removed Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed thing type on README and some case on xml thing types Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md cutted part about manually thing config specs on README . Who use oh already knows it . Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Code cleanup and optimizations based on @Skinah tips Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes from @Skinah suggestions Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Fixed typeid's on costants files Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various optimizations follow @Skinah tips (thanks!) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes constants and channel id types of t31 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fix various NPE warnings Fixes many ... Some added suppresswarnings. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericActionMessage.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Refactor handlers into souliss.internal.handler Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spoless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix t19 (securesend parm ,labels and setvalue) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Null checks Warnings removed (mitigated with local copy of field) - removed comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * syntax sugar fixed of consts and section removed from README Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * moved files to internal package Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissHandlerFactory.java check types on object and not on strings Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Gateway ip address regex on config param Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * changed description of gateway ip on param Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * formatted tables in README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip for npe checks - breaking functionality :-( Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless fix Author: Luca Calcaterra <calcaterra.luca@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix contrib header in some files Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * reworked udp - only one bridge allowed and UDP listen only to bridge port 230 ...passing datagramsocket with soulissnetworkparameter class Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * quite ok. Where to close socket in case of thread interruption ? Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip2 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip3 udp receive but not on vpn Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Classes names Refactor Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * replaced datagramsocket with nio socket- seems to be ok Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fixed some null checks removed securesend option (only t11 end similar) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * dummy initial value of raw values - removed thread on decoder line Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix t19 ex catch and broadcast function Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Reworked Config of Gateway as Class (todo check nulls...) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Added representation property on gw - some cleanups Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java cleanup unused vars Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * refactor methods of gw parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP to remove NetworkParameter class Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip refactor DiscoverResult Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip remove networkparameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP remove NetworkParameter Class. Things online only on a health message Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP Fix Topics Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP2 Fix topics Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml upgrade binding version to 3.2 snapshot Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * topics bound to bridge - seems to be ok. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * remove NetworkParameters class - topics ok but need parse rework Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * code cleanup and bugs check fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Add node and slot to property - other fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * change default interval subscription -cleanup constants Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP WAN Address gw Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WAN option external network. Fixed Putin on commands - to test well Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup - safesend check WIP Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed secursend for t11-18 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP Fix null checks Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericHandler.java fixed wrong assignment of prop Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * null checks fixes for code quality Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed listen port according to gw parm (default 23000) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * nuances Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml changed default values Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * CommonCommands to static - other fixes . seems quite ok, remain T31 to fix (securesend) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java changed executor imp for udp Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * restored commoncommands non static Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SendDispatcherRunnable.java safesendcheck fix (not really) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various nuances (sonarlint) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md removed explain how oh works on example Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/feature/feature.xml Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * @fwolter various fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java wrong header Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix headers descriptions before authors on all classes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * all var on begin of classes and @nullable sugar syntax Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed @nullable on local vars Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip comments translations and cleanup Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup comments and translated them (if italian occourred) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * @fwolter suggestions for approval...various fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter suggestions. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter suggestions. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java hexutils usage Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT22Handler.java removed unused method Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT22Handler.java fix previous commit Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java @nullable on configuration Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * method to put bridge offline (network exception on listener) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml changed some channels to trigger type Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP broken Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml spotless:apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various changes call super on initialize() of all handlers. Changed to QuantityType where appliable Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java added uniqueId (ip of gateway+node+slot) as representationProperty Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip for load discovery component Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * big fixes and code quality improvments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericHandler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md wrong format .. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix null soulissGwHandler and code analysis Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java Comment removed Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java cleanup ... Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java reintroduced local var for avoid SAT warning Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java fix error ...nuances Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-authored-by: Tonino Fazio <fazioa@gmail.com> Co-authored-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Renamed healty in healthy (simple word error) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml onOff to CamelCase Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * camelCase fixed on some types Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed camelCase on thhings parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml fixed label cases Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Revert "Update thing-types.xml" This reverts commit 5c19fbc. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fix some errors (Nullable issues) and pom.xml format Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java Default case on switch (handlecommand ) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * added secoresend to t31 skeleton and variable smessage fix declaration Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Initial Contribution Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml spotless-apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-Authored-By: Tonino Fazio <fazioa@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java Cutted comments and uneccessary log on gw status Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Renamed healty in healthy (simple word error) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed camelCase on thhings parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup and quality code fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingUDPDecoder.java fixed some npe Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * npe check fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java Remove comments unused code Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java commented out code unused Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissCommonCommands.java remove unused code commented out Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingUDPServerJob.java remove unused code comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissBindingSendDispatcherJob.java fixed logger trace and remove unused code comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed completely unnecessary comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed some thing types cases Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java removed unnecessary log line Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java removed unnecessary comment Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * loggers as final ! Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayJobHealthy.java removed unnecessary logs Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayJobPing.java removed unnecessary logs Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed redundancy on types checks Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md fixed examples parms Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java changed parm var name bridge Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT11Handler.java remove comments Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT12Handler.java comments removed Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/java/org/openhab/binding/souliss/handler/SoulissT13Handler.java comments removed Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed thing type on README and some case on xml thing types Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md cutted part about manually thing config specs on README . Who use oh already knows it . Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Code cleanup and optimizations based on @Skinah tips Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes from @Skinah suggestions Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Fixed typeid's on costants files Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various optimizations follow @Skinah tips (thanks!) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes constants and channel id types of t31 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fix various NPE warnings Fixes many ... Some added suppresswarnings. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericActionMessage.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Refactor handlers into souliss.internal.handler Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spoless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix t19 (securesend parm ,labels and setvalue) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless:apply fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Null checks Warnings removed (mitigated with local copy of field) - removed comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * syntax sugar fixed of consts and section removed from README Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * moved files to internal package Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissHandlerFactory.java check types on object and not on strings Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Gateway ip address regex on config param Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * changed description of gateway ip on param Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * formatted tables in README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed comments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip for npe checks - breaking functionality :-( Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * spotless fix Author: Luca Calcaterra <calcaterra.luca@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix contrib header in some files Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * reworked udp - only one bridge allowed and UDP listen only to bridge port 230 ...passing datagramsocket with soulissnetworkparameter class Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * quite ok. Where to close socket in case of thread interruption ? Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip2 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip3 udp receive but not on vpn Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Classes names Refactor Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * replaced datagramsocket with nio socket- seems to be ok Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Fixed some null checks removed securesend option (only t11 end similar) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * dummy initial value of raw values - removed thread on decoder line Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix t19 ex catch and broadcast function Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Reworked Config of Gateway as Class (todo check nulls...) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Added representation property on gw - some cleanups Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java cleanup unused vars Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * refactor methods of gw parameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP to remove NetworkParameter class Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip refactor DiscoverResult Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip remove networkparameters Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP remove NetworkParameter Class. Things online only on a health message Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP Fix Topics Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP2 Fix topics Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update pom.xml upgrade binding version to 3.2 snapshot Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * topics bound to bridge - seems to be ok. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * remove NetworkParameters class - topics ok but need parse rework Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * code cleanup and bugs check fix Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Add node and slot to property - other fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * change default interval subscription -cleanup constants Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP WAN Address gw Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WAN option external network. Fixed Putin on commands - to test well Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup - safesend check WIP Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed secursend for t11-18 Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP Fix null checks Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericHandler.java fixed wrong assignment of prop Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * null checks fixes for code quality Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixed listen port according to gw parm (default 23000) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * nuances Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml changed default values Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * CommonCommands to static - other fixes . seems quite ok, remain T31 to fix (securesend) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java changed executor imp for udp Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * restored commoncommands non static Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SendDispatcherRunnable.java safesendcheck fix (not really) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various nuances (sonarlint) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md removed explain how oh works on example Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update bundles/org.openhab.binding.souliss/src/main/feature/feature.xml Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * @fwolter various fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java wrong header Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix headers descriptions before authors on all classes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * all var on begin of classes and @nullable sugar syntax Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * removed @nullable on local vars Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip comments translations and cleanup Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * cleanup comments and translated them (if italian occourred) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * @fwolter suggestions for approval...various fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter suggestions. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various fixes based on @fwolter suggestions. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayHandler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update UDPListenDiscoverRunnable.java hexutils usage Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT22Handler.java removed unused method Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT22Handler.java fix previous commit Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissT11Handler.java @nullable on configuration Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * method to put bridge offline (network exception on listener) Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml changed some channels to trigger type Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * WIP broken Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update thing-types.xml spotless:apply Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * various changes call super on initialize() of all handlers. Changed to QuantityType where appliable Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java added uniqueId (ip of gateway+node+slot) as representationProperty Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * wip for load discovery component Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * big fixes and code quality improvments Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fixes Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGenericHandler.java Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update README.md wrong format .. Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * fix null soulissGwHandler and code analysis Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java Comment removed Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java cleanup ... Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java reintroduced local var for avoid SAT warning Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> * Update SoulissGatewayDiscovery.java fix error ...nuances Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com> Co-authored-by: Tonino Fazio <fazioa@gmail.com> Co-authored-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.