[phc] Fix OH3 bug and add support for multiple commands #11554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
lolodomo
changed the title
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* Remove advanced option in group-type Signed-off-by: Jonas Hohaus <jh@gnlpf.net> * Add support for multiple commands in one message Signed-off-by: Jonas Hohaus <jh@gnlpf.net> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
* Remove advanced option in group-type Signed-off-by: Jonas Hohaus <jh@gnlpf.net> * Add support for multiple commands in one message Signed-off-by: Jonas Hohaus <jh@gnlpf.net> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* Remove advanced option in group-type Signed-off-by: Jonas Hohaus <jh@gnlpf.net> * Add support for multiple commands in one message Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Remove advanced option in group-type Signed-off-by: Jonas Hohaus <jh@gnlpf.net> * Add support for multiple commands in one message Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Remove advanced option in group-type Signed-off-by: Jonas Hohaus <jh@gnlpf.net> * Add support for multiple commands in one message Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overdue update / bug fix:
Remove the advanced option from jrmTime channel group.
The error has probably crept in again with the last correction and newly added JRM things in OH3 no longer worked.
Link to the Community: https://community.openhab.org/t/phc-binding-throwing-exception-on-startup/111774/2
Support multible commands in one received serial message.
Sometimes modules seem to send commands for several channels in one message.
Link to the Community: https://community.openhab.org/t/switch-from-peha-phc-to-new-automation-with-openhab2/61154/49
Signed-off-by: Jonas Hohaus jh@gnlpf.net